fix(fabric): Switch default Text color to labelColor#2878
Merged
Saadnajmi merged 2 commits intomicrosoft:mainfrom Mar 31, 2026
Merged
fix(fabric): Switch default Text color to labelColor#2878Saadnajmi merged 2 commits intomicrosoft:mainfrom
Saadnajmi merged 2 commits intomicrosoft:mainfrom
Conversation
|
Collaborator
Author
|
/backport 0.81-stable |
Backport results
|
acoates-ms
approved these changes
Mar 30, 2026
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Apr 2, 2026
3 tasks
Saadnajmi
added a commit
that referenced
this pull request
Apr 3, 2026
## Summary Backport of 3 fixes from `main` to `0.81-stable`: - **fix(fabric):** Switch default Text color to `labelColor` (#2878) - **fix(fabric):** fix Text overflow in ScrollView on first render (#2880) - **fix(fabric):** Add back compat layer for `validKeysDown` and `validKeysUp` (#2879) Each fix is a separate commit for easy rebasing when upstream PRs are updated. ### Conflict resolutions - **PR #2878:** 0.81-stable uses `RCTUIColor` (renamed from `RCTPlatformColor` on main). Resolved by keeping `RCTUIColor` while applying the `blackColor` → `labelColor` change. - **PRs #2880 and #2879** cherry-picked cleanly. #2879 (open PR) was squash-cherry-picked into a single commit. ## Test plan - [ ] Verify default text color respects dark/light mode - [ ] Verify Text in ScrollView renders correctly on first load - [ ] Verify legacy `validKeysDown`/`validKeysUp` props still work in Fabric 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We've had this diff for both iOS and macOS in Paper, let's bring it to Fabric. Slightly more complicated because the shared C++ actually sets the default to black, which isn't good for Dark mode.
Test Plan: