Integrate RN 0.85.0-nightly-20260128-36f07a1b2#16245
Open
anuagragith wants to merge 6 commits into
Open
Conversation
Includes: - Full nightly integration with conflict resolution - Fix C++ compile errors from nightly integration - Fix AnimationBackend linker errors from nightly integration - Fix X86 build (suppress C4018 signed/unsigned mismatch in MapBuffer.cpp) - Sync stale copy overrides in @react-native/tester - Update yarn.lock and add change files Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- snapshotPages Text 33: Add new FiraCode font variant examples - TextComponentTest borders: Adjust visual tree sizes (138→139, 20→19) - TouchableComponentTest: Add PositionInSet/SizeofSet accessibility props Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…tly pinning The nightly fixup regex in creaternwlib.cmd and creaternwapp.cmd was replacing all @react-native/*-config and *-preset package versions with the exact nightly version. However, @react-native/jest-preset was not published until Feb 2026 (earliest: 0.85.0-nightly-20260219), while our target nightly is from Jan 2026 (0.85.0-nightly-20260128-36f07a1b2). This caused yarn install to fail with 'No candidates found'. Fix: Add a negative lookahead (?!jest-preset) to skip this package. It will remain at the 'nightly' dist-tag which resolves to a valid version. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
/azp run #Resolved |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). #Resolved |
Contributor
There was a problem hiding this comment.
Please provide context about changes in this file. #Resolved
Contributor
Author
There was a problem hiding this comment.
Same as Text.windows.js - just syncing with the upstream feature flag removal and new component syntax, while keeping the Win32-specific accessibility props intact, to the best of my understanding
vmoroz
approved these changes
Jun 12, 2026
Instead of suppressing SDL-mandatory warnings (which could break BinSkim), create a local patched copy in TEMP_UntilReactCommonUpdate with proper static_casts to fix signed/unsigned comparison warnings in upstream code. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JunielKatarn
approved these changes
Jun 15, 2026
vineethkuttan
left a comment
vineethkuttan
left a comment
Contributor
There was a problem hiding this comment.
Add the issue number for the changes added to the fork file
| networkAgentId_ = std::nullopt; | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Create a issue describing why these changes have been added and add the issue id here in the code
refer https://github.com/microsoft/react-native-windows/wiki/Integration-Process#overriding-files--errors-in-reactcommon
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ |
Contributor
There was a problem hiding this comment.
Create issue for this file also
Contributor
|
No pipelines are associated with this pull request. |
This was referenced Jun 16, 2026
- MapBuffer.cpp: #16261 (C4018/C4267 signed/unsigned fixes) - AnimatedPropSerializer.cpp: #16262 (Windows Color struct conversion) - NetworkIOAgent.cpp: #16263 (destructor and enableAgent/disableAgent API) Added // [Windows #issue] comments and registered overrides in overrides.json per integration process guidelines. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Performance Test ResultsBranch: ✅ Passed161 scenario(s) across 28 suite(s) — no regressionsSectionList
FlatList
TouchableOpacity
ScrollView
TouchableHighlight
Pressable
Modal
Image
ActivityIndicator
Switch
Button
TextInput
View
Text
SectionList.native-perf-test.ts
FlatList.native-perf-test.ts
TouchableHighlight.native-perf-test.ts
TouchableOpacity.native-perf-test.ts
Pressable.native-perf-test.ts
ScrollView.native-perf-test.ts
ActivityIndicator.native-perf-test.ts
TextInput.native-perf-test.ts
Switch.native-perf-test.ts
Button.native-perf-test.ts
Modal.native-perf-test.ts
Image.native-perf-test.ts
View.native-perf-test.ts
Text.native-perf-test.ts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integrate RN Nightly Build 0.85.0-nightly-20260128-36f07a1b2 - This PR integrates React Native Windows with a newer upstream React Native nightly build (Jan 28, 2026), advancing from the previous checkpoint of Jan 14, 2026. RNW is currently several months behind the latest RN nightly, so we are catching up in +14 day increments. This is the first PR in a series of catch-up integrations to bring RNW back to parity with the latest RN nightlies.
Please note:
This is my first attempt at RN → RNW integration. I used the integration script as a starting point and leveraged AI to help resolve merge conflicts, build issues, and linker errors, while reviewing and validating the resulting changes throughout the process.
In addition to ensuring the solution builds successfully, I validated the Playground app, including most controls and scenarios. Paid particular attention to the Text page, which had significant merge conflicts, and everything appears to be functioning correctly based on my testing.
Given the scope of the changes and the amount of conflict resolution involved, I'd appreciate a thorough review - especially for packages/@office-iss/react-native-win32/src-win/Libraries/Text/Text.win32.js to help catch anything that may have been inadvertently missed. Adding multiple reviewers to provide broader coverage across the different areas impacted by this integration. Thank you for taking a look.
Integration Details:
Commit range: react/react-native@f15985f...36f07a1
Type of Change
Why
Staying current with upstream ensures we pick up bug fixes, API changes, and performance improvements from core React Native, and reduces the risk of large, painful integrations later.
What
Integrate RN Nightly Build 0.85.0-nightly-20260128-36f07a1b2
Screenshots
N/A
Testing
Javascript validation:
⚠️ Flow — Version mismatch (pre-existing): config requires ^0.298.0, installed version is 0.296.1
✅ yarn build (lage monorepo) — All packages pass
✅ yarn lint (ESLint) — 0 errors (21 pre-existing warnings)
✅ node --check on all resolved files — No syntax errors
✅ No conflict markers in repo — Confirmed via grep
✅ Metro bundle loads successfully — JS bundle served at localhost:8081
Native Build Validation:
✅ NuGet restore — Passed
✅ ReactCommon.vcxproj compile — Passed
Included MapBuffer C4267 suppression
Included AnimationBackend source files
✅ Microsoft.ReactNative.vcxproj compile — Passed
✅ Microsoft.ReactNative.vcxproj link — Passed
AnimationBackend symbols resolved successfully
✅ Playground-Composition.vcxproj compile — Passed
✅ Full solution build — Build succeeded
Playground App Validation:
✅ App launch (playground-composition) — Successful
✅ Metro bundler — Serving JavaScript correctly
✅ File → Open JavaScript File → RNTester samples — Loads successfully
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow