Fix build mode setup stall on large solutions#4658
Open
johnfav03 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Optimizes watch setup for large build-mode solutions by replacing repeated full directory-map scans with indexed coverage checks.
Changes:
- Adds
DirWatchSetwith constant-time exact lookup and recursive-watch scanning. - Integrates it into build-mode and standard watcher setup.
- Adds coverage, casing, and recursive-upgrade unit tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/execute/watchmanager/watchmanager.go |
Implements DirWatchSet. |
internal/execute/watchmanager/watchmanager_test.go |
Tests watch-set behavior. |
internal/execute/watcher.go |
Uses indexed coverage for standard watch setup. |
internal/execute/build/orchestrator.go |
Optimizes build-mode watch computation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4614
On a large
tsc -b --watchproject-references solution,Found 0 errors. Watching for file changesprints within a few seconds, but filesystem watches aren't registers untilcomputeDesiredWatchesreturns, which can take tens of seconds. Edits are also silently dropped during this timeframe.computeDesiredWatchescallsIsDirCoveredByWatchonce per input file, buildinfo file, andpackage.jsonancestor across all projects, which linearly scans the entireDesiredDirsmap on every call. The set construction here is essentially O(files x dirs); by using a new data structure calledDirWatchSet, we can reduce this to O(files x recursive dirs). In the case of the example given in the linked issue, the ~1,534 desired dirs drop to ~15 recursive dirs while the number of files remains the same.