[libmodplug] [ffmpeg] fix libmodplug .pc file for static windows build

[mcmtroffaes]

• What does your PR fix?

  Fixes the libmodplug .pc file on windows (user32 is needed). Patch has been posted upstream here: Fix Libs.private in .pc file. Konstanty/libmodplug#59 I've enabled windows static builds for the ffmpeg modplug feature as well.

• Which triplets are supported/not supported? Have you updated the CI baseline?

  Libmodplug now additionally supports all static windows triplets.

• Does your PR follow the maintainer guide?

  Yes, to the best of my knowledge.

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  Yes.

[NancyLi1013]

Could you please update

file(COPY ${SOURCE_PATH}/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/libmodplug)
file(RENAME ${CURRENT_PACKAGES_DIR}/share/libmodplug/COPYING ${CURRENT_PACKAGES_DIR}/share/libmodplug/copyright)

as

file(INSTALL ${SOURCE_PATH}/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/{PORT} RENAME copyright)
?

[dg0yt]

file(INSTALL ${SOURCE_PATH}/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/{PORT} RENAME copyright)

@NancyLi1013 Are you aware that the RENAME argument is not a documented feature? If it is meant to be used even more in vcpkg, a documentation request should be made at Kitware.

[mcmtroffaes]

Could you please update

file(COPY ${SOURCE_PATH}/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/libmodplug)
file(RENAME ${CURRENT_PACKAGES_DIR}/share/libmodplug/COPYING ${CURRENT_PACKAGES_DIR}/share/libmodplug/copyright)

Done.

Are you aware that the RENAME argument is not a documented feature? If it is meant to be used even more in vcpkg, a documentation request should be made at Kitware.

Yes, that would be great.

[NancyLi1013]

file(INSTALL ${SOURCE_PATH}/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/{PORT} RENAME copyright)

@NancyLi1013 Are you aware that the RENAME argument is not a documented feature? If it is meant to be used even more in vcpkg, a documentation request should be made at Kitware.

Thanks for pointing this out. @dg0yt Currently, there is no any documentation that declares how we should use RENAME in handling license. We suggest to handle like this is just to reduce codes.

You can also see this here.

[NancyLi1013]

LGTM, thanks again for your fixes. @mcmtroffaes

[mcmtroffaes]

Merged master & bumped port version.