Skip to content

Ignore unknown properties in ICSS :import blocks #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NgoQuocViet2001 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ignore unknown properties in ICSS :import blocks #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/services/lint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,9 +388,10 @@ export class LintVisitor implements nodes.IVisitor {
// Unknown propery & When using a vendor-prefixed gradient, make sure to use them all.
/////////////////////////////////////////////////////////////

const isExportBlock = node.getSelectors().matches(":export");
const selectors = node.getSelectors();
const isICSSBlock = selectors.matches(':export') || (selectors.startsWith(':import(') && selectors.endsWith(')'));

if (!isExportBlock) {
if (!isICSSBlock) {
const propertiesBySuffix = new NodesByRootMap();
let containsUnknowns = false;

Expand Down
1 change: 1 addition & 0 deletions src/test/css/lint.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ suite('CSS - Lint', () => {
assertRuleSet('selector { box-shadow: none }'); // no error
assertRuleSet('selector { box-property: "rest is missing" }', Rules.UnknownProperty);
assertRuleSet(':export { prop: "some" }'); // no error for properties inside :export
assertRuleSet(':import("something.scss") { __customProperty: customProperty; }'); // no error for properties inside :import
assertRuleSet2('selector { foo: "some"; bar: 0px }', [], undefined, new LintConfigurationSettings({ validProperties: ['foo', 'bar'] }));
assertRuleSet2('selector { foo: "some"; }', [], undefined, new LintConfigurationSettings({ validProperties: ['foo', null] }));
assertRuleSet2('selector { bar: "some"; }', [Rules.UnknownProperty], undefined, new LintConfigurationSettings({ validProperties: ['foo'] }));
Expand Down