Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/htmlLanguageTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,12 @@ export interface Node {
children: Node[];
parent?: Node;
attributes?: { [name: string]: string | null } | undefined;
/**
* Returns true if this is a `<script type="module">` node.
* Module scripts have isolated scopes per the HTML specification,
* unlike classic scripts which share a global scope.
*/
readonly isModule: boolean;
}

export enum TokenType {
Expand Down
12 changes: 12 additions & 0 deletions src/parser/htmlParser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,18 @@ export class Node {
public endTagStart: number | undefined;
public attributes: { [name: string]: string | null } | undefined;
public get attributeNames(): string[] { return this.attributes ? Object.keys(this.attributes) : []; }
public get isModule(): boolean {
if (this.tag !== 'script') {
return false;
}
const type = this.attributes?.type;
if (!type) {
return false;
}
// Attribute values are stored with surrounding quotes (e.g., '"module"' or "'module'")
const unquoted = type.replace(/^['"]|['"]$/g, '');
return unquoted === 'module';
}
constructor(public start: number, public end: number, public children: Node[], public parent?: Node) {
}
public isSameTag(tagInLowerCase: string | undefined) {
Expand Down
32 changes: 32 additions & 0 deletions src/test/parser.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,36 @@ suite('HTML Parser', () => {
children: []
}]);
});

test('Script isModule', () => {
// Module scripts have isolated scopes (issue #133)
const doc1 = parse('<script type="module">let a = 0;</script>');
assert.strictEqual(doc1.roots[0].isModule, true);

// Classic scripts share the global scope
const doc2 = parse('<script>let a = 0;</script>');
assert.strictEqual(doc2.roots[0].isModule, false);

// Single-quoted attribute value
const doc3 = parse("<script type='module'>let a = 0;</script>");
assert.strictEqual(doc3.roots[0].isModule, true);

// Other type values are not modules
const doc4 = parse('<script type="text/javascript">let a = 0;</script>');
assert.strictEqual(doc4.roots[0].isModule, false);

// Non-script tags are not modules
const doc5 = parse('<div type="module"></div>');
assert.strictEqual(doc5.roots[0].isModule, false);

// Multiple scripts: module scripts have isolated scopes
const doc6 = parse('<script type="module">let a = 0;</script><script type="module">let a = 0;</script>');
assert.strictEqual(doc6.roots[0].isModule, true);
assert.strictEqual(doc6.roots[1].isModule, true);

// Mixed: module and classic scripts
const doc7 = parse('<script type="module">let a = 0;</script><script>let a = 0;</script>');
assert.strictEqual(doc7.roots[0].isModule, true);
assert.strictEqual(doc7.roots[1].isModule, false);
});
});