Skip to content

Some refactoring around inline script manager - #1685

Open
StellaHuang95 wants to merge 2 commits into
microsoft:mainfrom
StellaHuang95:refactor-inline-error-message
Open

Some refactoring around inline script manager#1685
StellaHuang95 wants to merge 2 commits into
microsoft:mainfrom
StellaHuang95:refactor-inline-error-message

Conversation

@StellaHuang95

Copy link
Copy Markdown
Contributor

This PR addresses the following feedback:

  1. Make error message handling a helper function.
  2. Move all inline script related files into its own subfolders.

No code logics or implementations are changed, it's pure refactoring to address previous feedback.

@edvilme edvilme left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread src/features/inlineScript/lazyDetector.ts
Comment thread src/managers/builtin/inlineScript/envManager.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants