fix(linux): convert StartupWMClass template values to lowercase - #327720
Open
TumnusVirus wants to merge 8 commits into
Open
fix(linux): convert StartupWMClass template values to lowercase#327720TumnusVirus wants to merge 8 commits into
TumnusVirus wants to merge 8 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Linux packaging to align StartupWMClass with lowercase runtime identifiers.
Changes:
- Transforms the desktop template value for DEB, RPM, and Snap packages.
- Current transformation incorrectly produces triple hyphens for names such as
Code - OSS.
Comments suppressed due to low confidence (2)
build/gulpfile.vscode.linux.ts:162
- The RPM path has the same invalid derivation:
Code - OSSbecomescode---oss, which cannot match thecode-ossruntime WM class. Use the existing product application name rather than converting the display name.
.pipe(replace('@@NAME_SHORT@@', product.nameShort.toLowerCase().replace(/ /g, '-')))
build/gulpfile.vscode.linux.ts:249
- The Snap desktop file will also get
code---ossfor the default product (and an analogous triple-hyphen Insiders value), so itsStartupWMClassremains mismatched. Populate it fromapplicationName, which is already the runtime/package identifier.
.pipe(replace('@@NAME_SHORT@@', product.nameShort.toLowerCase().replace(/ /g, '-')))
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux .deb installer creates duplicate desktop shortcuts leading to startup crash loops and orphaned crashpad handlers on Ubuntu MATE
#327088
When VS Code or VS Code Insiders compiles on Linux, it sets StartupWMClass using standard camel-case names, but the underlying runtime engine launches as low-case code or code-insiders, breaking taskbar icon-grouping window mappings on Linux panels like Ubuntu MATE.
Whenever a new version of code or code-insiders is downloaded for me, it opens up the URL handler desktop instead of the main desktop. With this change, it should no longer happen. I've gone into the code.desktop / code-insiders.desktop folder and updated it to code or code-insiders and it no longer exhibits that behaviour.