fix: memory leak in notebook view model - #328208
Merged
dmitrivMS merged 3 commits intoJul 31, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes retention of deleted notebook cell view models by removing and disposing them from the notebook view model’s disposable store.
Changes:
- Dispose and unregister deleted cell view models.
- Add regression coverage verifying disposal occurs exactly once.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
notebookViewModelImpl.ts |
Removes deleted cells from the disposable store. |
notebookViewModel.test.ts |
Tests immediate disposal without repeated teardown disposal. |
meganrogge
approved these changes
Jul 30, 2026
meganrogge
approved these changes
Jul 30, 2026
meganrogge
approved these changes
Jul 30, 2026
Contributor
|
@SimonSiefke thank you! |
dmitrivMS
enabled auto-merge (squash)
July 31, 2026 00:54
roblourens
approved these changes
Jul 31, 2026
dmitrivMS
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Deleted notebook cell view models stayed reachable through
NotebookViewModel's disposable store after their cells were removed.Change
Remove deleted cell view models from the disposable store, which also disposes them immediately.
Before
When splitting and joining a notebook cell 37 times,
CodeCellViewModelgrows once per iteration:After
No more
CodeCellViewModelleak is detected.Test Video
notebook-cell-split.webm