Empty array handling for ReportTemplate.html#1336
Open
rberghuis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Mobile Devices diagram received data but did no validation before handing it to the library. Two things were missing:
1. It passed zero-value links
If a tenant has no mobile devices, all the mobile links have value 0. Those zeros were passed straight to d3-sankey, which tried to draw a chart with no meaningful data.
2. It had no guard for empty data.
When all links are zero, filtering them out leaves an empty dataset. d3-sankey then tried to compute
new Array(max_depth + 1)wheremax_depthisundefined(no nodes to measure), which evaluates tonew Array(NaN), an invalid operation that crashes the whole page.The fix adds two lines of defence: