fix(export): don't crash on shift slot ids > 289 (out-of-range Options index)

[renemadsen]

The bug

The all-workers (and single-worker) timeplanning Excel export threw and aborted:

Error while filling data row: Index was out of range ...
  at System.Collections.Generic.List`1.get_Item(Int32 index)
  at ...FillDataRow(...) at ...GenerateExcelDashboard(...ReportForAllWorkers...)

Root cause

GetShiftTime resolved a shift's time by indexing plr.Options — a fixed 288-element list (slots 1–288 → "00:00".."23:55", only 289 special-cased to "24:00"). A shift slot id ≥ 290 indexes past the end → IndexOutOfRange. The Pause columns are the worst case: they always pass actualStamp=null, so they hit this lookup even when UseOneMinuteIntervals is on.

Confirmed against real data: a customer site had Pause1Id = 388 and 517 (both > 288) — exactly the crash.

The fix

Compute the time arithmetically — minutes = (shift-1)*5, formatted HH:mm — instead of indexing Options. This reproduces the old output exactly for the valid 1–288 range, keeps 289 → "24:00", and extends gracefully past midnight (290 → "24:05", 313 → "26:00"). No array index, no crash. (Drop-in; the now-unused plr param is kept to avoid touching ~15 call sites — a separate cleanup.)

Tests (the coverage gap)

• Unit: GetShiftTime across the valid range, 289, out-of-range (290/313), 0/null — PlanRegistrationHelperTests (shard f).
• Export regression: seeds out-of-range Stop1Id=313 + Pause1Id=295 and asserts both export overloads succeed and render "26:00" — DagsoversigtWorksheetExportTests (shard g). Verified it fails without the fix.

Separate follow-ups (not in this PR)

1. The bad Pause1Id values (≈32–43 h) are a data/encoding bug upstream — the existing if (Start1Id > 289) workaround doesn't cover Pause or shifts 2–5, nor run at export time.
2. Export temp filenames use second-resolution UtcNow with no uniqueness → concurrent exports can collide on the same path.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Fixes a production crash in the TimePlanning Excel export caused by out-of-range shift slot IDs (>= 290) by switching GetShiftTime from plr.Options indexing to arithmetic time computation, and adds unit + export regression tests to lock the behavior.

Changes:

• Compute shift slot time as (shift-1)*5 minutes to avoid IndexOutOfRangeException in exports.
• Add unit coverage for GetShiftTime(plr, shift) including cross-midnight/out-of-range slot IDs.
• Add an end-to-end export regression test that seeds out-of-range Stop1Id/Pause1Id and validates both export overloads succeed and render "26:00".

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn/Services/TimePlanningWorkingHoursService/TimePlanningWorkingHoursService.cs	Replaces plr.Options indexing with arithmetic formatting for shift slot IDs to prevent export crashes.
eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn.Test/PlanRegistrationHelperTests.cs	Adds unit test cases covering valid, boundary, and out-of-range slot IDs for the 2-arg GetShiftTime.
eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn.Test/DagsoversigtWorksheetExportTests.cs	Adds regression test ensuring both export paths handle cross-midnight/out-of-range shift IDs without throwing and with correct output.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.