Add precommit checks and format sources#83
Open
r38y wants to merge 2 commits into
Open
Conversation
- Apply Mix formatting to config, library, and test files - Normalize missing trailing newlines
- Add mix precommit alias for formatting, compile, and tests - Run the precommit alias in the test environment - Document repository contribution guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mix formatwhile working on Handle Req transport errors #82mix precommitto check formatting, compile with warnings as errors, and run tests before commitsAGENTS.mdwith repository contributor guidanceThis came out of running
mix formatin #82, which changed unrelated code. This PR should maybe be merged first, thenmix formatcan be run again in #82.The
AGENTS.mdmay be controversial. I am happy to revert it or change it if you do not want it in this repo.