Skip to content

Fix CI breakage from no-test coverage handling and deprecated setup-go action#170

Draft
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-ci-broken-on-base-branch
Draft

Fix CI breakage from no-test coverage handling and deprecated setup-go action#170
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-ci-broken-on-base-branch

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 22, 2026

Base branch CI was failing even when tests passed: make test exited non-zero due to go: no such tool "covdata" on coverage processing, and workflows were still pinned to deprecated actions/setup-go@v3.

  • CI workflow modernization

    • Updated Go setup action in CI workflows:
      • .github/workflows/go.yml
      • .github/workflows/go-pr.yml
    • Replaced actions/setup-go@v3 with actions/setup-go@v5.
  • Makefile test target hardening

    • Changed make test to compute package list from go list and include only packages that actually contain test files.
    • Coverage output is now generated only for test-bearing packages, avoiding covdata failures caused by coverage processing on no-test packages.
  • Behavioral impact

    • Preserves current test execution flow and coverage generation (cover.out) for real test packages.
    • Removes CI instability from packages under ./... that have code but no _test.go files.
@TEST_PKGS=$$(go list -tags $(BUILD_TAGS) -f '{{if or .TestGoFiles .XTestGoFiles}}{{.ImportPath}}{{end}}' $(GO_TARGET)); \
if [ -n "$$TEST_PKGS" ]; then \
	go test -tags $(BUILD_TAGS) -v $$TEST_PKGS -coverprofile cover.out; \
else \
	go test -tags $(BUILD_TAGS) -v $(GO_TARGET); \
fi

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 22, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Copilot
Once this PR has been reviewed and has the lgtm label, please ask for approval from kaovilai. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI changed the title [WIP] Fix CI issue on base branch due to missing covdata tool Fix CI breakage from no-test coverage handling and deprecated setup-go action May 22, 2026
Copilot AI requested a review from kaovilai May 22, 2026 04:25
@github-actions
Copy link
Copy Markdown

@kaovilai Please add a comment with /ok-to-test to trigger the e2e

3 similar comments
@github-actions
Copy link
Copy Markdown

@kaovilai Please add a comment with /ok-to-test to trigger the e2e

@github-actions
Copy link
Copy Markdown

@kaovilai Please add a comment with /ok-to-test to trigger the e2e

@github-actions
Copy link
Copy Markdown

@kaovilai Please add a comment with /ok-to-test to trigger the e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI broken on base branch: missing covdata tool + deprecated actions

2 participants