ci: unblock fork CI (rustfmt drift, pin sqlx-cli, skip remote-checks on forks)#21
Merged
Conversation
rename_workspace_branch's match expression wasn't rustfmt-clean on main, so cargo fmt --all --check (the tauri-checks CI job) failed on every commit. No behavior change.
Unpinned sqlx-cli resolves to 0.9.0, which requires rustc 1.94+ and fails to install on the repo's pinned nightly (rustc 1.93). Masked upstream by a warm cache; fresh forks fail at setup. Pin to the project's sqlx 0.8.x.
miguelrisero
changed the title
The job builds crates/remote, which pulls the private BloopAI/vibe-kanban-private 'billing' crate via VK_PRIVATE_DEPLOY_KEY. Forks can't access it, so the job can never pass there. Gate it on github.event.repository.fork == false; it still runs on the canonical (non-fork) repo.
miguelrisero
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three pre-existing issues that fail
test.ymlon a fresh fork — independent of any feature work, surfaced when CI was first enabled:rename_workspace_branch(crates/server/.../git.rs) brokecargo fmt --all --check→backend-clippy(its backgrounded fmt check) andtauri-checks. Fixed viacargo fmt --all(one file, no behavior change).sqlx-cliresolved to0.9.0, which needs rustc 1.94+ and won't install on the repo's pinned nightly (rustc 1.93) → brokebackend-schema-checkssetup. Masked upstream by a warm cache. Pinned tosqlx-cli@0.8.6(matches the project's sqlx 0.8.x).backend-remote-checkscan't run on forks — it buildscrates/remote→ the privateBloopAI/vibe-kanban-privatebillingcrate. Gated it ongithub.event.repository.fork == falseso it skips on forks and still runs upstream.Result on this fork:
changes,frontend-checks,backend-schema-checks,backend-clippy,backend-test,tauri-checksgreen;backend-remote-checksskipped.