Fix counting problem with list_dump_filedescriptor#12
Open
dangarbri wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list_dump_filedescriptordoesn't return the right length in the output when elements are variable size.There were 3 things contributing to the counting error:
rndtermvalue at the end wasn't being counted.sizeof(header)but the header isn't "packed" so sizeof(header) == 32 on some systems (i.e. mine) instead of 30. Thatuint16_tactually takes up 4 bytes so the memory accesses are on dword lines.I added a new variable
extra_byteswhich counts 1 and 2, and I changedsizeof(header)toSIMCLIST_DUMPFORMAT_HEADERLENto fix 3.This patch is compatible with existing list dumps, it just fixes the number that
list_dumpfiledescriptorreturns.