[mike-ainsel]

Merge v4-beta into v4: #221 (tell a new version from a new package with npm 10+).

The tree is v4-beta with the @v4-beta -> @v4 self-ref rewrite only. The plain merge-beta.sh merge duplicated hunks (a second prepare step in node-simple.yaml, a second isPublished in registry.ts) because #219 reached v4-beta as a squash and v4 as an amended commit; the merge commit's tree was replaced with v4-beta's to drop them.

Confidence Score: 4/5

The PR appears safe to merge, with a non-blocking test gap around errors from the second lookup.

Findings

1.  Second lookup errors lack tests ▶

Fix with agent prompt

### Issue 1
actions/node/npm-split-publish/src/registry.ts:72
The new error branch has no test. `registryRunner` returns `E500` on the first lookup for packages in `failing`, so the existing error test never reaches this branch. A later change could treat a registry outage or access error as “package missing” without failing the tests.

Add a case where the version lookup returns `E404` and the package lookup returns `E500` or `E403`. Assert that `versionState` throws with the second command and its error.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

This PR fixes how versionState tells a new version from a new package when npm returns E404 for both.

• Registry checks tell a new version from a new package on npm 10+.

Important touched terms:

• VersionState — The three possible states: published, new-version, and new-package. Its definition is unchanged; the new lookup improves which state is returned.
• Runner — A function that runs a command and returns a RunResult. Its type is unchanged; versionState now uses it for a second lookup after E404.
• RunResult — A command’s exit code, standard output, and error output. Its shape is unchanged; the test helpers now model npm 10+ and legacy responses.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A["Look up name@version"] --> B{"Result"}
  B -->|"Version found"| C["published"]
  B -->|"Success, no output"| D["new-version"]
  B -->|"E404"| E["Look up package name"]
  B -->|"Other error"| F["Throw CommandError"]
  E --> G{"Result"}
  G -->|"Name found"| D
  G -->|"E404 or success with no output"| H["new-package"]
  G -->|"Other error"| F

Loading

_{Reviews (1) · Last reviewed commit: "Merge v4-beta into v4" · Reviewed by Greptile}

[greptile-apps]

Second lookup errors lack tests

The new error branch has no test. registryRunner returns E500 on the first lookup for packages in failing, so the existing error test never reaches this branch. A later change could treat a registry outage or access error as “package missing” without failing the tests.

Add a case where the version lookup returns E404 and the package lookup returns E500 or E403. Assert that versionState throws with the second command and its error.

Prompt To Fix With AI

This is a comment left during a code review.
Path: actions/node/npm-split-publish/src/registry.ts
Line: 72

Comment:
**Second lookup errors lack tests**

The new error branch has no test. `registryRunner` returns `E500` on the first lookup for packages in `failing`, so the existing error test never reaches this branch. A later change could treat a registry outage or access error as “package missing” without failing the tests.

Add a case where the version lookup returns `E404` and the package lookup returns `E500` or `E403`. Assert that `versionState` throws with the second command and its error.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.