Repository navigation
fix(logging): keep agent diagnostics quiet and correlated (ENG-3579) - #621
Merged
Merged
Conversation
Refs: ENG-3579
This was referenced Oct 21, 2026
Merged
Merged
Merged
lucas-koontz
marked this pull request as ready for review
October 21, 2026 07:32
Refs: ENG-3579
mindsdb-devops
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User story
As an on-call engineer
I want quiet, correlated diagnostics
So that I can diagnose failures without exposing customer data
Why this matters
Operators currently sift through agent chatter to find a failed turn. JSON diagnostics now default to WARNING and retain safe exception locations and conversation correlation. Cloud-turn JSONL and the separate usage stream keep their existing contracts.
Visual review
A deployed before/after capture remains a rollout gate for this runtime. Local regression and container evidence below establish behavior, not a production volume reduction.
Acceptance criteria
docs/structured-logging.md.How to test
uv run pytest tests/test_diagnostics.py tests/test_cloud_turn_resident.py tests/test_cloud_turn_provider_logging.py tests/test_image_smoke.py.Notes for the reviewer
Current review validation
The resident entrypoint regression failed in all four JSON/text and default/DEBUG combinations before the fix. The final affected suite passes all 62 cases in the Linux Python 3.12 container, including resident lifecycle and image smoke tests; Ruff and diff checks pass. Local macOS coverage passed 42 cases with 20 Linux-only skips before the Linux rerun.
The combined source API/web arm64 images also rebuilt successfully. Container smoke verified the installed Anton version
2.26.10.21.2rc3.dev2+gb73859e9f, matching this commit, alongside the reviewed server version. It passed health/routing, refusal visibility and private-value exclusion; it does not establish provider-backed agent turns or a released package.The hosted workflow also passed its test suite and checks on this commit.
Earlier validation
These broader results precede the resident follow-up:
Ships with
mindsdb/cowork-server#741, mindsdb/cowork#1263, mindsdb/data-vault#5, mindsdb/mindshub#12504.
Merge/release order: #621, then mindsdb/cowork-server#741, then mindsdb/cowork#1263. mindsdb/data-vault#5 can proceed independently. Update reviewed release pins and rebuild mindsdb/mindshub#12504 last.