Merge pull request #90 from stof/fix_phpstan

Fix the phpstan CI job

Author: stof

composer.json

@@ -20,7 +20,7 @@
     "require": {
         "php": ">=7.2",
         "ext-json": "*",
-        "behat/mink": "^1.9",
+        "behat/mink": "^1.11",
         "symfony/error-handler": "^4.4 || ^5.0 || ^6.0 || ^7.0",
         "symfony/phpunit-bridge": "^4.4 || ^5.4 || ^6.0 || ^7.0",
         "phpunit/phpunit": "^8.5.22 || ^9.5.11",

src/FixturesKernel.php

@@ -11,7 +11,7 @@
 
 class FixturesKernel implements HttpKernelInterface
 {
-    public function handle(Request $request, $type = self::MASTER_REQUEST, $catch = true): Response
+    public function handle(Request $request, $type = 1 /* self::MAIN_REQUEST */ , $catch = true): Response
     {
         $this->prepareSession($request);
 

tests/Js/EventsTest.php

@@ -2,6 +2,7 @@
 
 namespace Behat\Mink\Tests\Driver\Js;
 
+use Behat\Mink\KeyModifier;
 use Behat\Mink\Tests\Driver\TestCase;
 
 final class EventsTest extends TestCase
@@ -86,6 +87,8 @@ public function testMouseOver(): void
     }
 
     /**
+     * @param KeyModifier::*|null $modifier
+     *
      * @dataProvider provideKeyboardEventsModifiers
      */
     public function testKeyboardEvents(?string $modifier, string $eventProperties): void
@@ -118,11 +121,11 @@ public static function provideKeyboardEventsModifiers(): iterable
     {
         return [
             'none' => [null, '0 / 0 / 0 / 0'],
-            'alt' => ['alt', '1 / 0 / 0 / 0'],
+            'alt' => [KeyModifier::ALT, '1 / 0 / 0 / 0'],
             // jQuery considers ctrl as being a metaKey in the normalized event
-            'ctrl' => ['ctrl', '0 / 1 / 0 / 1'],
-            'shift' => ['shift', '0 / 0 / 1 / 0'],
-            'meta' => ['meta', '0 / 0 / 0 / 1'],
+            'ctrl' => [KeyModifier::CTRL, '0 / 1 / 0 / 1'],
+            'shift' => [KeyModifier::SHIFT, '0 / 0 / 1 / 0'],
+            'meta' => [KeyModifier::META, '0 / 0 / 0 / 1'],
         ];
     }
 }