Merged
Conversation
…mmit hash in the version. Remove the "dirty" flag from wallet version response. Print a warning if versions of wallet-cli, wallet-rpc-daemon and the node differ.
ImplOfAnImpl
force-pushed
the
add_version_response_to_binaries
branch
from
f06b070 to
f969d3e
Compare
OBorce
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--versionparameter was added to executables that didn't have it (wallet-rpc-daemon,dns server,api-web-server,api-blockchain-scanner-daemon).wallet/build.rswas moved to a function in a separate crateutils/build_utils. Also, a rebuild is now triggered when the git hash changes.All
--versionresponses now have the git commit hash as the build metadata.GIT_TREE_CLEANbuild env var, which was set inwallet/build.rs, was removed because it doesn't seem to be possible to set it reliably on a dev machine (and it shouldn't be set on CI anyway).wallet-clinow prints a warning to the log if its, node's and wallet-rpc-daemon's versions don't match (the metadata is ignored during comparison).