fix(tapis): skip FIXED inputs in job submission#116
Merged
Conversation
FIXED inputs are locked by the app definition; Tapis injects them from the app at submission. createJobFileInputsFromSeed previously required every app fileInput to have a matching model.input_files entry, throwing "Component input not found" for FIXED inputs since they are not exposed to the model component. Skip FIXED inputs in the job request (Tapis fills them in).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TapisJobService.createJobFileInputsFromSeedthrewComponent input not foundwhen an appfileInputhadinputMode: FIXED. FIXED inputs are locked by the app definition (sourceUrl pre-set) and have no entry inmodel.input_files, so the lookup failed.inputMode === FIXEDplus regression tests for FIXED-only and mixed (OPTIONAL+FIXED) apps.Test plan
npx jest src/classes/tapis/adapters/tests/jobs.test.ts— 6/6 passnpx jest src/classes/tapis— 19/19 pass