fix(tapis): tolerate empty-string parameter bindings#117
Merged
Conversation
POST /executionEngines/tapis crashed with "Cannot read properties of undefined (reading 'match')" when an input parameter had no default value and the user-supplied binding was an empty string. The empty string is falsy, so neither branch in getInputsParameters assigned parameters[ip.id], and the subsequent regex check on the value threw. The crash propagated into handleSubmissionFailure, which then crashed on this.seeds.length because seeds was never initialized before seedExecutions threw. The cleanup mutation never ran and the original error was masked. - Guard the geojson regex with optional chaining so undefined values pass through unchanged. - Initialize this.seeds = [] at the start of submitExecutions so the failure cleanup path always has a valid array. - Add unit tests covering empty-string, populated, and default-value parameter cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
submitExecutionsto avoid Tapis crashsrc/classes/tapis/tests/helpers.test.tsTest plan
npm testpasses locally