fix(tapis): map Hasura output shape in getModelOutputsByModelId#118
Merged
Conversation
matchTapisOutputsToMintOutputs crashed with TypeError reading 'name' on undefined
because getModelOutputsByModelId returned the raw Hasura response
(outputs[].output.{id,label,has_format}) while typed as ModelOutput[]
({position, model_io:{id,name,format,variables}}). The matcher accessed
mintOutput.model_io.name on the raw shape and threw.
Extracted mapHasuraOutputsToModelOutputs and added unit tests covering the
real Hasura payload, null/undefined input, and missing fields. Function now
returns [] instead of null on errors to match its declared return type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
matchTapisOutputsToMintOutputscrashed in production withTypeError: Cannot read properties of undefined (reading 'name')when fetching subtask outputs.getModelOutputsByModelIdreturned the raw Hasura response (outputs[].output.{id,label,has_format}) while typed asModelOutput[]({position, model_io:{id,name,format,variables}}). The matcher accessedmintOutput.model_io.nameon the raw shape and threw. DYNAMO v2.0 migration debt — type lied; test fixture used the typed shape so unit tests passed while prod failed.mapHasuraOutputsToModelOutputsand call it insidegetModelOutputsByModelId. Return[]instead ofnullon errors to match the declared return type.Test plan
npx jest src/classes/graphql/graphql_functions.test.ts— 4/4 pass (real Hasura payload, null/undefined input, missing fields, missing label/has_format)npx jestfull suite — 77/77 pass (includes existingmatchTapisOutputsToMintOutputstest)npm run build— webpack compiles cleanGET /v1/problemStatements/.../subtasks/.../outputsagainst a Tapis-backed execution and confirm 200 with mapped results