feat(upload): stamp backend-vended metadata onto uploaded objects#177
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ben-miru
marked this pull request as ready for review
July 17, 2026 22:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UploadWithCredentials) vends ametadatamap carrying object provenance (e.g.device_id,release_id,digest); the agent previously dropped it, so uploaded objects landed in the bucket without it. This threads the map generically — no key inspection — from the create-upload response through theObjectTransferseam onto the wire.s3::Storestamps the map asx-amz-meta-*headers onPutObjectandCreateMultipartUpload(parts/complete and resumed uploads inherit from initiation per S3 semantics);gcs::Storestamps it as custom object metadata in the object-resource JSON. An empty map adds no headers, keeping requests byte-identical to before.SdkTransferagainst replayed S3.Plan:
plans/completed/20260717-store-upload-metadata.md🤖 Generated with Claude Code
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.