Repository navigation
Run the node signal adapters on every replica, not only the leader - #11
Merged
kylan11 merged 1 commit intoOct 19, 2026
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
standInReadyconsults that replica's own in-memorysignal.Registry. On a replica without the lease the registry never holds cordon or taint dooms. WithreplicaCount: 2, the production recommendation, an eviction served by the standby is admitted while the only ready stand-in sits on another cordoned or tainted node (a node pool upgrade or a multi-node drain), where the leader would correctly keep holding.NeedLeaderElection: falseon both adapters. They only read nodes from the shared cache and write the in-memory registry, so running them on every replica is safe and adds no API writes.Verification
mainits registry never sees a cordoned or a tainted node (the spec times out). With this change both appear, and the manager never becomes leader.make test lint buildand theARGO_ROLLOUTS_CRD="Optional Rollout API" run: passed, no generated-file drift.🤖 Generated with Claude Code