Conversation
6422e7b to
ae4b395
Compare
de8090e to
2c9c0f9
Compare
2c9c0f9 to
11c4c0b
Compare
There was a problem hiding this comment.
what if some call fails?
There was a problem hiding this comment.
The code above attaches handlers for the success case of deferred but doesn't actually resolve or reject the initial promise until this line. We need to resolve the initial promise so that it can start evaluating the other success callbacks. To illustrate:
deferred -> task1 -> task2 -> task3
deferred is always resolved. It doesn't do anything but we need to attach the task chain to something we have control of. Then task1 is evaluted. It returns a promise that's either rejected or resolved depending on how the AJAX request went. If task1 succeeded task2's success handler is then executed.
If task1 failed it would try to execute task2's failure handler, or task3, or whatever the next in line with a failure handler is. None of them have failure handlers so we just stop executing the chain in the event of a AJAX failure.
|
@pdpinch ? |
|
Only two comments about the UI and one minor in the code. |


Fixes #111