Popover datepicker optimization#2517
Open
mfal wants to merge 3 commits into
Open
Conversation
Contributor
Coverage Report for ./packages/components/
File CoverageNo changed files found. |
mfal
force-pushed
the
popover-datepicker-optimization
branch
from
57924e9 to
ed7ef2c
Compare
Contributor
🚀 Preview DeploymentPreview environments are ready:
Images:
|
ins0
added
the
update-screenshots
github-actions
Bot
removed
the
update-screenshots
mfal
force-pushed
the
popover-datepicker-optimization
branch
from
72faaa1 to
13523e6
Compare
mfal
added
the
update-screenshots
github-actions
Bot
removed
the
update-screenshots
Contributor
🚀 Preview DeploymentPreview environments are ready:
Images:
|
Co-authored-by: mfal <4696750+mfal@users.noreply.github.com>
Member
|
it does not look good without padding, maybe we should add a --calendar--cell-size-mobile instead? |
Contributor
🚀 Preview DeploymentPreview environments are ready:
Images:
|
Member
|
we need this optimization for date range picker as well |
Lisa18289
reviewed
Jun 26, 2026
|
|
||
| const calendarClassName = clsx( | ||
| styles.calendar, | ||
| getBodyInnerWidth() < 300 && styles.small, |
Member
There was a problem hiding this comment.
could we not just use css media query instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.