chore: address review cleanup#15
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR performs “review cleanup” maintenance across CI/release automation and labeling logic, including a behavioral fix to trend_scanning_labels to avoid defaulting flat/no-trend cases to a negative label.
Changes:
- Adjust
trend_scanning_labelsto emit null labels (and associated outputs) when no directional trend is detected; add a regression test for flat price series. - Pin GitHub Actions dependencies (by commit SHA where applicable) and pin
uvto a fixed version; update CI/docs workflows to pass explicit--pythontouv sync. - Housekeeping: relax the
numpyupper bound inuv.lock, fix a test comment, and remove an unreferenced docs SVG asset.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Updates numpy upper-bound constraint. |
tests/test_new_labeling_methods.py |
Adds regression test for null-label behavior in flat/no-trend trend scanning. |
tests/features/volatility/test_volatility_comprehensive.py |
Corrects Bollinger Bands test comment to match behavior. |
src/ml4t/engineer/labeling/horizon_labels.py |
Changes trend scanning labeling to avoid default -1 when best_t == 0; nulls out t_value when appropriate. |
docs/images/ml4t_ecosystem_workflow_color.svg |
Removes the SVG asset (no in-repo references found). |
.github/workflows/release.yml |
Pins uv version; pins PyPI publish action to a commit SHA. |
.github/workflows/docs.yml |
Pins uv version; pins deploy action to a commit SHA; passes explicit --python to uv sync. |
.github/workflows/ci.yml |
Pins uv version; passes explicit --python to uv sync across jobs. |
.github/dependabot.yml |
Switches Dependabot ecosystem from pip to uv for uv.lock updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address review cleanup backlog.