ci: validate PyTorch MPS support#8
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds first-class validation for PyTorch MPS usage by extending the internal torch runtime helpers and introducing both unit tests and a macOS CI smoke job to ensure MPS is actually available and usable on Apple Silicon runners.
Changes:
- Extend
resolve_device()andseed_torch()to support the PyTorch MPS backend when available. - Add unit tests covering device resolution and seeding dispatch for CPU/CUDA/MPS using a small fake torch shim.
- Add a macOS (Apple Silicon) CI smoke job to verify
torch.backends.mpsis built/available and that basic tensor ops run on MPS.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/test_torch_runtime.py |
Adds unit tests validating device resolution and seeding behavior across CPU/CUDA/MPS. |
src/ml4t/models/_internal/torch_runtime.py |
Implements MPS-aware device selection and MPS seeding support. |
.github/workflows/ci.yml |
Adds a macOS MPS smoke job and gates the build on it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+19
to
21
| requested_device = requested.strip().lower() | ||
| if requested_device.startswith("cuda") and torch.cuda.is_available(): | ||
| return torch.device(requested) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@/tmp/ml4t-models-mps-pr-body.md