fix: normalize CUDA device requests#9
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves PyTorch device resolution by normalizing CUDA device request strings (trimming whitespace and lowercasing) before constructing a torch.device, preventing failures on inputs like " CUDA:0 ".
Changes:
- Normalize CUDA device request strings in
resolve_device()before callingtorch.device(...). - Add a regression test that asserts whitespace/case variants of CUDA device requests resolve correctly when CUDA is available.
- Bump package version to
0.1.0a5and update release notes and lockfile dependency bounds (NumPy<2.6).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updates the locked NumPy specifier to permit NumPy 2.5.x (<2.6). |
| tests/test_torch_runtime.py | Adds coverage ensuring CUDA device requests are normalized before device construction. |
| src/ml4t/models/_internal/torch_runtime.py | Normalizes CUDA device strings passed into torch.device(...). |
| src/ml4t/models/init.py | Bumps __version__ to 0.1.0a5 (used for hatch dynamic versioning). |
| CHANGELOG.md | Adds 0.1.0a5 release notes including the CUDA normalization fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@/tmp/ml4t-models-a5-pr-body.md