Open
Conversation
Contributor
Author
|
Hi @mmcdole, would you mind giving a feedback, whether this has any chance of getting included and/or what is needed to do so? (I also noted, that the coverage bot avoids this PR...) |
Owner
|
@Necoro thanks for the submission. Can you provide a bit more context around the problem for me, just so I grok it. Do you often find atom tags within RSS feeds? |
Contributor
Author
|
@mmcdole |
Merged
Contributor
Author
…y atom is allowed as part of RSS
…e a json roundtrip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As needed per #151, I added parsing of atom tags in RSS.
This adds a mechanism to add a parser for certain extension namespaces. This is now only implemented for calling Atom from RSS. This avoids re-handling Atom in RSS by calling the Atom parser directly.
The implementation tries to be very agnostic: the RSS parser knows nothing about Atom. I played with the idea of removing the abstraction and couple them tighter, but the result was not that different -- so I settled with the nicer agnostic one.
The translation phase, of course, is not agnostic anymore, because it has to know what to put where.
Remarks:
*atom.Entry.atom/parser.go#ParseAsExtension), because I do not know the idea behind base and the url stack.actualobject take a JSON-detour (i.e., en- then decoded) to match theexpected.authorandupdated. If more are needed, they need to be added.Resolves #151