ENH: Replace custom _whosmat_hdf5 with pymatreader.whosmat#13753
Merged
larsoner merged 5 commits intomne-tools:mainfrom Apr 3, 2026
Merged
ENH: Replace custom _whosmat_hdf5 with pymatreader.whosmat#13753larsoner merged 5 commits intomne-tools:mainfrom
larsoner merged 5 commits intomne-tools:mainfrom
Conversation
Remove the custom _whosmat_hdf5 function and delegate to pymatreader.whosmat (available since v1.2.2), which handles all MATLAB file versions including v7.3 (HDF5). Pin pymatreader >= 1.2.2 accordingly.
larsoner
reviewed
Mar 16, 2026
Since pymatreader.whosmat was only released ~2 weeks ago (v1.2.2), it's too recent to require as a minimum version. Move the custom _whosmat_hdf5 implementation to mne/fixes.py and add a _whosmat wrapper that tries pymatreader.whosmat (>= 1.2.2) first, falls back to scipy.io.whosmat, then to the custom h5py-based reader. Revert min_version="1.2.2" requirements from check.py, pyproject.toml, and environment.yml.
Updated the description of the changes related to MATLAB v7.3 file inspection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_whosmat_hdf5function (~98 lines) and delegate topymatreader.whosmat(available since v1.2.2), which handles all MATLAB file versions including v7.3 (HDF5)pymatreader >= 1.2.2inpyproject.tomland propagate toenvironment.ymlmin_version="1.2.2"to_import_pymatreader_funcsand_check_pymatreader_installedCloses #13752
Test plan
python -c "from mne.io.eeglab._eeglab import _readmat"— import succeedspython -m pytest mne/io/eeglab/tests/test_eeglab.py -x— no failures