-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fixed some info fields in MEG interpolation across sensor types using… #13759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7b76111
fixed some info fields in MEG interpolation across sensor types using…
chsquare 8313af6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 707f73f
incorporated feedback on pull request #13759
chsquare bb72caf
Revert "incorporated feedback on pull request #13759"
chsquare 99f531e
Merge branch 'master' of https://github.com/chsquare/mne-python
chsquare 900c81e
incorporated feedback on pull request #13759 again
chsquare 896b585
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 8efb756
avoid deepcopy in _interpolate_to_meg because not necessary
chsquare 01975f7
added test for _interpolate_to_meg that supposedly fails on main and …
chsquare b60a965
added test for _interpolate_to_meg that supposedly fails on main and …
chsquare 4536e44
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e04159b
fix merge conflict due to auto-formatting
chsquare 8c63131
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure we need
deepcopyhere, sinceinfo_canois instantiated within the function (not user-passed) and not otherwise needed, so there's no real risk to it getting mutated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right - I removed the deepcopy.