Skip to content

fix(test): merge project-level use into config for actionTimeout and other options#220

Open
sarang-code2 wants to merge 1 commit into
mobile-next:mainfrom
sarang-code2:fix/config-scope
Open

fix(test): merge project-level use into config for actionTimeout and other options#220
sarang-code2 wants to merge 1 commit into
mobile-next:mainfrom
sarang-code2:fix/config-scope

Conversation

@sarang-code2

Copy link
Copy Markdown

The device fixture only reads top-level config.use, silently ignoring options set inside config.projects[].use like actionTimeout, appLaunchTimeout, installTimeout, and animations.

Finds the matching project by name via testInfo.project.name and merges its use into the top-level use before passing to connectDevice.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c03e5834-1f74-4cd6-bdbf-68f5f50d5490

📥 Commits

Reviewing files that changed from the base of the PR and between 0ec4c07 and 28c9355.

📒 Files selected for processing (1)
  • packages/test/src/fixtures.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/test/src/fixtures.ts

Walkthrough

The device fixture now locates the current Playwright project, merges its use settings with global config.use, and assigns the resulting projectUse configuration to the merged fixture config. This applies project-level overrides during device allocation and connection alongside the existing platform, device name, and app installation overrides.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main fix: merging project-level use settings into the device fixture config.
Description check ✅ Passed The description directly matches the change by explaining that project-level use is merged before connectDevice.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gmegidish

Copy link
Copy Markdown
Member

@sarang-code2 and also sign this commit :)

…other options

The device fixture only read top-level config.use, silently ignoring
options set inside config.projects[].use like actionTimeout,
appLaunchTimeout, installTimeout, and animations.

Now finds the matching project by name from testInfo.project.name and
merges its use into the top-level use before passing to connectDevice.
@sarang-code2

Copy link
Copy Markdown
Author

@gmegidish Ready to merge 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants