Repository navigation
Run the eval by hand, and ignore a tap's click in t23 - #24
Merged
Merged
Conversation
launchd's default spawn type broke the emulator's audio: 12 captures in 18 split a tone, 0 in 15 with ProcessType Interactive, 0 in 8 from a shell. The Mac also slept about 15 minutes inside runs. Remove the schedule, and run weekly from a shell under caffeinate. t23's reference counted a tap's 0.1 s click as a tone. Ignore sounds of 200 ms or less, as Mobium's expect does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
t23's reference failed on every logged night, so the Android controls read as untrusted. GitHub's Android job passed throughout.
Same Mobium, APK, emulator flags and cold boot, in daytime:
ProcessTypeInteractiveA split capture holds gaps of about 100 ms inside the tone, so the tone did break. Why the spawn type causes it is inferred, not measured.
The power log also shows the Mac asleep about 15 minutes inside runs on three nights.
What changes
nightly/install.shand the launchd plist.nightly.shsay to run weekly by hand:caffeinate -i nightly/nightly.sh. GitHub's scheduled Controls stay.[780, 440, 880]. A split longer than that still fails.Tested
pytest: 80 passed, with a new test for the click.[440, 880]. That line prints the filtered list, so these runs do not show whether a click was dropped; the test covers that path.Not tested:
caffeinate -ithrough a full run.