constraintenforcer: ignore completed tasks in reservation accounting#3237
Merged
thaJeztah merged 1 commit intoJun 8, 2026
Merged
Conversation
Completed tasks (especially from replicated-job history) should not consume node reservations in the constraint enforcer. Add a regression test covering completed job tasks. Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
Contributor
Author
|
Quick sync note: this change is the upstream fix for the behavior reported in moby/moby#52652. |
This was referenced May 28, 2026
Member
|
@dperny care to have a look? |
Contributor
Author
|
@dperny Can you check it out and drop suggestions if any? |
Contributor
Author
|
Hey just following up on this. |
dperny
approved these changes
Jun 5, 2026
Contributor
Author
|
Thanks for taking a look and for the approval! Just checking if there's anything else needed from my side before this can be merged. Happy to make any additional changes if required. |
lohitkolluri
added a commit
to lohitkolluri/moby
that referenced
this pull request
Jun 8, 2026
Update swarmkit to latest master to include the upstream fix for constraint enforcer counting completed replicated-job tasks against node capacity (moby/swarmkit#3237). Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
lohitkolluri
added a commit
to lohitkolluri/moby
that referenced
this pull request
Jun 8, 2026
Update swarmkit to latest master to include the upstream fix for constraint enforcer counting completed replicated-job tasks against node capacity (moby/swarmkit#3237). Fixes moby#52652 Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
addresses moby/moby#52652