fix(tools): allow entering decimal values like 1.0 in parameter fields (#918)#1614
Open
asif786ka wants to merge 1 commit into
Open
fix(tools): allow entering decimal values like 1.0 in parameter fields (#918)#1614asif786ka wants to merge 1 commit into
asif786ka wants to merge 1 commit into
Conversation
Number parameter inputs collapsed partial decimals (for example 1.0) to integers while typing because HTML number inputs reject values like 1. and immediately coerced valid floats to integer display values. Use text inputs with decimal input mode for number schema fields, defer committing trailing-zero decimals until blur, and add regression tests (issue modelcontextprotocol#918).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.0can be entered without collapsing to1while typing.inputMode="decimal"fornumberschema fields and defer committing trailing-zero decimals until blur.ToolsTab.1.0digit-by-digit entry.Type of Change
Testing
Checklist
Fixes #918
Made with Cursor