fix: clean up STDIO sessions after disconnect#1649
Open
kmishra1204 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction proof
The new integration test aborts the Inspector SSE connection while the STDIO child writes shutdown output to STDERR. On current
main, the proxy exits with the reportedSSEServerTransport.send(): Error: Not connectedstack. With this change, the proxy remains healthy and accepts a second STDIO connection.Testing
npm test --workspace=server(3 tests passed)npm run buildnpm run check-versioncd client && npm run lintproxyFetchEndpoint.test.tscould not bind its fixture in this Docker runner and fails identically on an untouchedupstream/mainsnapshotFixes #654
Disclosure: this contribution was developed with AI assistance and validated with local red/green runtime testing.