Address #179 so example in README.md will run#189
Closed
jwoehr wants to merge 1 commit into
Closed
Conversation
"class must be constructable through the container" Signed-off-by: Jack Woehr <jwoehr@softwoehr.com>
jwoehr
requested review from
CodeWithKyrian,
Nyholm and
chr-hertel
as code owners
Author
|
Now mysteriously seems to work without __construct. "Never mind ..." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"class must be constructable through the container"
Example didn't run as written.
Motivation and Context
Added a __construct and example works.
How Has This Been Tested?
Run at home.
Breaking Changes
No.
Types of changes
Checklist
Additional context
<