Skip to content

Re-export get_sequence_parallel_rank and get_sp_group from xfuser utils #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HaozheZhang6 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Re-export get_sequence_parallel_rank and get_sp_group from xfuser utils #1521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion diffsynth/utils/xfuser/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
from .xdit_context_parallel import usp_attn_forward, usp_dit_forward, usp_vace_forward, get_sequence_parallel_world_size, initialize_usp, get_current_chunk, gather_all_chunks
from .xdit_context_parallel import usp_attn_forward, usp_dit_forward, usp_vace_forward, get_sequence_parallel_world_size, get_sequence_parallel_rank, get_sp_group, initialize_usp, get_current_chunk, gather_all_chunks

@gemini-code-assist gemini-code-assist Bot Jul 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The import line is extremely long (over 210 characters), which violates PEP 8 recommendations (maximum line length of 79 characters) and makes the code harder to read and maintain. Wrapping the imported names in parentheses allows them to be cleanly formatted across multiple lines.

Suggested change
from .xdit_context_parallel import usp_attn_forward, usp_dit_forward, usp_vace_forward, get_sequence_parallel_world_size, get_sequence_parallel_rank, get_sp_group, initialize_usp, get_current_chunk, gather_all_chunks
from .xdit_context_parallel import (
usp_attn_forward,
usp_dit_forward,
usp_vace_forward,
get_sequence_parallel_world_size,
get_sequence_parallel_rank,
get_sp_group,
initialize_usp,
get_current_chunk,
gather_all_chunks,
)
References
  1. PEP 8 recommends limiting all lines to a maximum of 79 characters and using parentheses for multi-line imports. (link)