fix: anonymous volumes crash the emitter#11
Merged
Conversation
A single container-path volume (no source:target, e.g. /var/cache/models)
passed validate() but crashed run_flags at volume.split(':', 1). Emit it as an
anonymous volume (-v <path>) with no host-path translation, matching Compose
and podman semantics.
An anonymous volume must be an absolute container path. A colon-less entry that is not absolute (e.g. ./cache) is malformed Compose; validate() now raises instead of letting emit produce a broken -v ./cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash in 0.1.2 on Compose files with anonymous volumes, and cuts the 0.1.3 patch release.
Bug
A short-form volume that is a single container path with no
source:target(e.g.- /var/cache/models) passedvalidate()but crashedemit.run_flagsatvolume.split(":", 1)withValueError: not enough values to unpack. Hit on a real CI compose file.Fix
run_flagsemits a colon-less volume verbatim as-v <path>(anonymous volume; no host-path translation).validate()rejects a colon-less entry that is not absolute (e.g../cache) with a clear error, instead of letting emit produce a broken-v ./cache— keeping the loud-refusal contract.Independently reviewed (bug reproduced, fix confirmed); the relative-anonymous hardening addresses the reviewer's one finding. Rationale in
planning/changes/2026-07-08.02-anonymous-volumes.md; capability doc updated inarchitecture/supported-subset.md.Release
Bundles
planning/releases/0.1.3.mdso tagging0.1.3after merge publishes cleanly.Tests
just test-ci— 89 passed, 100% line coverage.just lint-ciclean.