test: grow the integration scenario set (network aliases, depends_on default)#45
Merged
lesnik512 merged 2 commits intoJul 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Grows the podman integration harness further with two more behavioral scenarios, per
planning/changes/2026-07-13.04-grow-integration-scenarios-aliases-depends-on.md. No harness,conftest.py,pyproject.toml, or CI config changes -- each scenario reuses the existingrun_podfixture.networks: {default: {aliases: [...]}}, a distinct code path from the hostname/container_name case already covered (graph.py:_host_names's aliases-extraction branch), even though the downstream--add-hostmerge is already proven.depends_onwith no condition -- defaults toservice_started, the one dependency condition with zero synchronization.helperstarts detached with no gate;apppolls with a bounded retry loop for a marker file, rather than checking once -- the correct shape for testing a condition whose entire point is "no wait is provided, the caller bridges the gap itself." Verified locally (via directemit_scriptgeneration, no podman) thathelperemits as plainpodman run -dand the retry loop's$(seq ...)survives compose2pod's own interpolation untouched, learning from the previous round's$-hijacking bug.Both underlying claims were independently traced to source and independently re-verified during review (not merely trusted), given two of the three prior rounds in this series shipped bugs that only source-tracing or real CI caught.
Verification
just test-ciat 100% (363 passed, 10 deselected);just lint-ciandjust check-planningclean. Both scenarios usebusybox:1.36, already cached. Behavioral green is produced by the existingintegrationCI job.