fix offset safety, rebalance handling, and commit error handling#9
Merged
fix offset safety, rebalance handling, and commit error handling#9
Conversation
Member
lesnik512
commented
Apr 14, 2026
lesnik512
commented
- batch_committer: stop advancing offsets at the first cancelled task per partition so messages aborted mid-flight are not silently skipped on restart
- batch_committer: separate CommitFailedError (rebalance, ignore) from KafkaError (transient, re-queue) so a terminal error no longer spins forever
- batch_committer: add _stop_requested flag so commit_all() flushes without stopping the loop (safe for rebalance), while close() still shuts it down
- processing: remove redundant observer task — the _finish_task done-callback already discards completed tasks immediately, making the observer a no-op
- rebalance: add ConsumerRebalanceListener that calls commit_all() on on_partitions_revoked to prevent duplicate processing after reassignment; accessible via KafkaConcurrentHandler.create_rebalance_listener()
- tests: cover all new behaviours; 100% branch coverage on changed modules
- batch_committer: stop advancing offsets at the first cancelled task per partition so messages aborted mid-flight are not silently skipped on restart - batch_committer: separate CommitFailedError (rebalance, ignore) from KafkaError (transient, re-queue) so a terminal error no longer spins forever - batch_committer: add _stop_requested flag so commit_all() flushes without stopping the loop (safe for rebalance), while close() still shuts it down - processing: remove redundant observer task — the _finish_task done-callback already discards completed tasks immediately, making the observer a no-op - rebalance: add ConsumerRebalanceListener that calls commit_all() on on_partitions_revoked to prevent duplicate processing after reassignment; accessible via KafkaConcurrentHandler.create_rebalance_listener() - tests: cover all new behaviours; 100% branch coverage on changed modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.