Skip to content

fix(mp7particledata): to_prp bug fix#2737

Merged
wpbonelli merged 1 commit intomodflowpy:developfrom
kallejahn:to-prp-fix
Mar 26, 2026
Merged

fix(mp7particledata): to_prp bug fix#2737
wpbonelli merged 1 commit intomodflowpy:developfrom
kallejahn:to-prp-fix

Conversation

@kallejahn
Copy link
Copy Markdown
Contributor

Small fix to iteration in NodeParticleData.to_prp().

Added another iteration through nodedata, as previously iteration only passed through the first node, so total particles could only equal the number of subdivisions. With fix total particles now equals the number of nodes times the number of subdivisions.

@wpbonelli wpbonelli added this to the 3.10.1 milestone Mar 24, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.4%. Comparing base (556c088) to head (65d1d53).
⚠️ Report is 146 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2737      +/-   ##
===========================================
+ Coverage     55.5%    72.4%   +16.9%     
===========================================
  Files          644      674      +30     
  Lines       124135   130670    +6535     
===========================================
+ Hits         68947    94684   +25737     
+ Misses       55188    35986   -19202     
Files with missing lines Coverage Δ
flopy/modpath/mp7particledata.py 88.4% <100.0%> (+<0.1%) ⬆️

... and 570 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@wpbonelli wpbonelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kallejahn !

@wpbonelli wpbonelli merged commit f0c0432 into modflowpy:develop Mar 26, 2026
20 checks passed
@wpbonelli wpbonelli added the bug label Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants