fix(mp7particledata): to_prp bug fix#2737
Merged
wpbonelli merged 1 commit intomodflowpy:developfrom Mar 26, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2737 +/- ##
===========================================
+ Coverage 55.5% 72.4% +16.9%
===========================================
Files 644 674 +30
Lines 124135 130670 +6535
===========================================
+ Hits 68947 94684 +25737
+ Misses 55188 35986 -19202
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix to iteration in
NodeParticleData.to_prp().Added another iteration through
nodedata, as previously iteration only passed through the first node, so total particles could only equal the number of subdivisions. With fix total particles now equals the number of nodes times the number of subdivisions.