Skip to content

Feat(hfb_util): add method for creating HFBs#2745

Draft
jlarsen-usgs wants to merge 6 commits intomodflowpy:developfrom
jlarsen-usgs:develop
Draft

Feat(hfb_util): add method for creating HFBs#2745
jlarsen-usgs wants to merge 6 commits intomodflowpy:developfrom
jlarsen-usgs:develop

Conversation

@jlarsen-usgs
Copy link
Copy Markdown
Contributor

@jlarsen-usgs jlarsen-usgs commented Apr 6, 2026

  • added make_hfb_array which supports HFB data creation from LineString / Grid intersections for all FloPy Grid types
  • added additional updates to support HFB creation development including
    • Grid: add cell_area property via the shoelace algorithm
    • GridIntersect: add "experimental" support for UnstructuredGrid
    • VoronoiGrid: add support for get_disu6_gridprops() that can build MF6 DISU packages

Updates support development of generalized HFB creation methods
* Grid: add cell_area property via the shoelace algorithm
* GridIntersect: add "experimental" support for UnstructuredGrid
* VoronoiGrid: add support for get_disu6_gridprops() that can build MF6 DISU packages
* add make_hfb_array and supporting methods to build HFB recarrays from LineString / Grid intersections
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 92.13483% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.5%. Comparing base (556c088) to head (3c4e190).
⚠️ Report is 150 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/utils/hfb_util.py 89.3% 20 Missing ⚠️
flopy/utils/gridintersect.py 87.5% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2745      +/-   ##
===========================================
+ Coverage     55.5%    72.5%   +17.0%     
===========================================
  Files          644      676      +32     
  Lines       124135   131196    +7061     
===========================================
+ Hits         68947    95218   +26271     
+ Misses       55188    35978   -19210     
Files with missing lines Coverage Δ
flopy/discretization/grid.py 74.8% <100.0%> (-1.2%) ⬇️
flopy/utils/__init__.py 100.0% <100.0%> (ø)
flopy/utils/voronoi.py 81.6% <100.0%> (+12.2%) ⬆️
flopy/utils/gridintersect.py 72.5% <87.5%> (-7.0%) ⬇️
flopy/utils/hfb_util.py 89.3% <89.3%> (ø)

... and 571 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* catches "mid cell split" and "colinear with cell boundary" edge cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant