Feat(hfb_util): add method for creating HFBs#2745
Draft
jlarsen-usgs wants to merge 6 commits intomodflowpy:developfrom
Draft
Feat(hfb_util): add method for creating HFBs#2745jlarsen-usgs wants to merge 6 commits intomodflowpy:developfrom
jlarsen-usgs wants to merge 6 commits intomodflowpy:developfrom
Conversation
Updates support development of generalized HFB creation methods * Grid: add cell_area property via the shoelace algorithm * GridIntersect: add "experimental" support for UnstructuredGrid * VoronoiGrid: add support for get_disu6_gridprops() that can build MF6 DISU packages
* add make_hfb_array and supporting methods to build HFB recarrays from LineString / Grid intersections
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2745 +/- ##
===========================================
+ Coverage 55.5% 72.5% +17.0%
===========================================
Files 644 676 +32
Lines 124135 131196 +7061
===========================================
+ Hits 68947 95218 +26271
+ Misses 55188 35978 -19210
🚀 New features to boost your workflow:
|
* catches "mid cell split" and "colinear with cell boundary" edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.