Nova variáveis para OPER by jpablofernandez · Pull Request #28 · monanadmin/MONAN-Model

jpablofernandez · 2026-04-01T17:17:25Z

Pull Request Description

Novas variáveis para OPER

Type of Change

Testing and Quality

Code was written following MONAN’s DTN-01 (Coding Standard)
Compilation and execution tests of the model were executed
Test with the debug flag was executed
Results are reproducible with the default configuration

Scientific Impact

None

joaomas · 2026-04-08T23:26:13Z

Tests Pool

Run date 00Z: 2024042000Z
Run date 12Z: 2026020912Z

Egeon: 24km

Test Compile: OK
Test 264h FCST 00Z: OK
Test 120h FCST 12Z: OK
Test Compile with debug flag: OK
Test 6h FCST 00Z with debug flag (all steps include static): ERROR

model.bash.e

At line 140 of file mpas_stability_indices.F
Fortran runtime error: Index '0' of dimension 1 of array 'p' below lower bound of 1

Error termination. Backtrace:
#5  0x88c235 in __mpas_atm_diagnostics_manager_MOD_mpas_atm_diag_compute
	at /mnt/beegfs/joao.messias/pr_pablo_git/scripts_CD-CT/sources/MONAN-Model_develop/src/core_atmosphere/diagnostics/mpas_atm_diagnostics_manager.F:115
At line 140 of file mpas_stability_indices.F
Fortran runtime error: Index '0' of dimension 1 of array 'p' below lower bound of 1

Code - mpas_stability_indices.F

DO 5 J=1,3
     DO 4 I=1,JNO
     IF (PL(J)-P(I)) 4,6,7
4    CONTINUE
     PRINT*,"RAOB TERMINATES TOO SOON, P(JNO) = ",P(JNO)
     RETURN
6    TL(J)=TS(I)
     TDL(J)=TSD(I)
     GO TO 5
7    FACTOR=ALOG(PL(J)/P(I))/ALOG(P(I-1)/P(I))
     TL(J)=TS(I)+FACTOR*(TS(I-1)-TS(I))
     TDL(J)=TSD(I)+FACTOR*(TSD(I-1)-TSD(I))
5    CONTINUE

Jaci: 10km

(Intel)
Test Compile: OK
Test 264h FCST 00Z: OK
Test 120h FCST 12Z: running...
Test Compile with debug flag:
Test 6h FCST 00Z with debug flag (all steps include static):

(GNU)
Test Compile: OK
Test 264h FCST 00Z: OK
Test 120h FCST 12Z: OK
Test Compile with debug flag: OK
Test 6h FCST 00Z with debug flag (all steps include static): ERROR (the same Egeon error)

joaomas

Conclusão:

Pull Request necessita de correção:

@jpablofernandez esta linha (140) do arquivo "mpas_stability_indices.F" esta gerando um erro na compilação com a flag debug ativa. A msg de erro é:

**"At line 140 of file mpas_stability_indices.F
Fortran runtime error: Index '0' of dimension 1 of array 'p' below lower bound of 1" **

Possivelmente causado pela subtração P(I-1) na primeira execução do laço, violando o índice do array iniciado em 1.

Para aceitarmos este Pull Request será necessário que estre trecho do código seja refeito.

Não será necessário um novo Pull Request, bastando apenas aplicar a correção e fazer um novo commit e nos comunicar.

Obrigado.

joaomas · 2026-04-14T12:38:34Z

+6    TL(J)=TS(I)
+     TDL(J)=TSD(I)
+     GO TO 5
+7    FACTOR=ALOG(PL(J)/P(I))/ALOG(P(I-1)/P(I))


@jpablofernandez esta linha (140) do arquivo "mpas_stability_indices.F" esta gerando um erro na compilação com a flag debug ativa. A msg de erro é:

**"At line 140 of file mpas_stability_indices.F
Fortran runtime error: Index '0' of dimension 1 of array 'p' below lower bound of 1" **

Possivelmente causado pela subtração P(I-1) na primeira execução do laço, violando o índice do array iniciado em 1.

Para aceitarmos este Pull Request será necessário que estre trecho do código seja refeito.

Não será necessário um novo Pull Request, bastando apenas aplicar a correção e fazer um novo commit e nos comunicar.

Obrigado.

joaomas

PRINT da linha 332 esta gerando 22 mil linhas no model.bash.o, verificar.

joaomas · 2026-04-14T12:56:00Z

+     DM=DELT-DELTM
+     IF(ABS(DM).GE.1.E-7) GO TO 10 ! IF DM VERY SMALL, ITERATION IS ENDLESS
+     TOL=ABS(DELT)
+     PRINT*,"TOLERANCE (TOL) IN DPTOF CHANGED TO ",TOL," (NORMAL TOL = .00010)"


@jpablofernandez este print tem gerado 22 mil linhas no arquivo model.bash.o

joaomas · 2026-04-22T14:00:46Z

Feito nova compilação com debug no novo commit e a rodada caiu um pouco antes de completar 3h de previsão.
Ele esta indicando erro aritmético na linha 215.

Segue:

model.bash.e

Program received signal SIGFPE: Floating-point exception - erroneous arithmetic operation.

Backtrace for this error:
#0  0x149afbea12e2 in ???
#1  0x149afbea0475 in ???
#2  0x149afbb5e97f in ???
#3  0x942193 in wobf
    at /p/projetos/monan_adm/joao.messias/pr_pablo_git_gnu/scripts_CD-CT/sources/MONAN-Model_develop/src/core_atmosphere/diagnostics/mpas_stability_indices.F:215
#4  0x943966 in __stability_indices_MOD_indx1
    at /p/projetos/monan_adm/joao.messias/pr_pablo_git_gnu/scripts_CD-CT/sources/MONAN-Model_develop/src/core_atmosphere/diagnostics/mpas_stability_indices.F:173
#5  0x8dbd11 in __mpas_convective_diagnostics_MOD_convective_diagnostics_compute
    at /p/projetos/monan_adm/joao.messias/pr_pablo_git_gnu/scripts_CD-CT/sources/MONAN-Model_develop/src/core_atmosphere/diagnostics/mpas_convective_diagnostics.F:557
#6  0x8c94d2 in __mpas_atm_diagnostics_manager_MOD_mpas_atm_diag_compute
    at /p/projetos/monan_adm/joao.messias/pr_pablo_git_gnu/scripts_CD-CT/sources/MONAN-Model_develop/src/core_atmosphere/diagnostics/mpas_atm_diagnostics_manager.F:115
#7  0x658b6f in __atm_core_MOD_atm_core_run
    at /p/projetos/monan_adm/joao.messias/pr_pablo_git_gnu/scripts_CD-CT/sources/MONAN-Model_develop/src/core_atmosphere/mpas_atm_core.F:823
#8  0x406a59 in __mpas_subdriver_MOD_mpas_run
    at /p/projetos/monan_adm/joao.messias/pr_pablo_git_gnu/scripts_CD-CT/sources/MONAN-Model_develop/src/driver/mpas_subdriver.F:416
#9  0x4051a2 in mpas
    at /p/projetos/monan_adm/joao.messias/pr_pablo_git_gnu/scripts_CD-CT/sources/MONAN-Model_develop/src/driver/mpas.F:20
#10  0x40520d in main
    at /p/projetos/monan_adm/joao.messias/pr_pablo_git_gnu/scripts_CD-CT/sources/MONAN-Model_develop/src/driver/mpas.F:10

Program received signal SIGFPE: Floating-point exception - erroneous arithmetic operation.

log.atmosphere.000.out

 Begin timestep 2024-04-20_02:58:00
 --- time to run the LW radiation scheme L_RADLW =F
 --- time to run the SW radiation scheme L_RADSW =F
 --- time to run the convection scheme L_CONV    =F
 --- time to apply limit to accumulated rainc and rainnc L_ACRAIN   =F
 --- time to apply limit to accumulated radiation diags. L_ACRADT   =F
 --- time to calculate additional physics_diagnostics               =F
  split dynamics-transport integration 3
 
 global min, max w -3.43613 10.6156
 global min, max u -83.7159 84.3462
  Timing for integration step: 3.24432 s
 
 Begin timestep 2024-04-20_02:59:00
 --- time to run the LW radiation scheme L_RADLW =F
 --- time to run the SW radiation scheme L_RADSW =F
 --- time to run the convection scheme L_CONV    =F
 --- time to apply limit to accumulated rainc and rainnc L_ACRAIN   =F
 --- time to apply limit to accumulated radiation diags. L_ACRADT   =F
 --- time to calculate additional physics_diagnostics               =T
  split dynamics-transport integration 3
 
 global min, max w -3.41939 10.1876
 global min, max u -84.0222 84.2399
  Timing for integration step: 3.40071 s

Linha 215:

WOBF=29.930/(POL*POL)+0.9600*X-14.800

Código estendido:

! CURVE FIT FOR WARMER TEMPERATURES
     POL=1.000+X*(3.6182989E-3+X*(-1.3603273E-5+X*(4.9618922E-7  &
       +X*(-6.1059365E-9+X*(3.9401551E-11+X*(-1.2588129E-13     &
       +X*(1.6688280E-16) ))))))
     POL=POL*POL
     WOBF=29.930/(POL*POL)+0.9600*X-14.800
     RETURN
     END

     REAL(kind=RKIND) FUNCTION SATLFT (THM,P)

joaomas · 2026-07-10T23:30:29Z

+6    TL(J)=TS(I)
+     TDL(J)=TSD(I)
+     GO TO 5
+7    IF (J.NE.1) GO TO 8 


Substituir linhas 143-147:

7 IF (J.NE.1) GO TO 8 IF (I.NE.1) GO TO 8 IHI=1 GO TO 5 8 FACTOR=ALOG(PL(J)/P(I))/ALOG(P(I-1)/P(I))

Por:

7 IF (I.NE.1) GO TO 8 IF (J.EQ.1) IHI=1 ! SFC PRESSURE LESS THAN 850 hPa TL(J)=9.96921e+36 TDL(J)=9.96921e+36 GO TO 5 8 FACTOR=ALOG(PL(J)/P(I))/ALOG(P(I-1)/P(I))

OBS: Sugestão Claude IA, verificar impacto científico do resultado.

joaomas · 2026-07-10T23:31:08Z

+
+! COMPUTE LIFTED INDEX
+
+     RLI=TL(3)-TP500                            ! LIFTED INDEX


Substituir linha 154:

RLI=TL(3)-TP500

Por:

IF (TL(3).GE.9.9e+36) THEN RLI=9.96921e+36 ELSE RLI=TL(3)-TP500 ENDIF

OBS: Sugestão Claude IA, verificar impacto científico do resultado.

joaomas · 2026-07-10T23:32:05Z

+!     WRITE(*,*)
+!     WRITE(*,80) TL(3),TP500
+
+     IF (IHI.EQ.0) GO TO 9   ! COMPUTE K AND SHOWALTER INDICES


Substituir linha 159:

IF (IHI.EQ.0) GO TO 9

Por:

IF (IHI.EQ.0 .AND. TL(2).LT.9.9e+36 .AND. TL(3).LT.9.9e+36) GO TO 9

OBS: Sugestão Claude IA, verificar impacto científico do resultado.

jpablofernandez added 4 commits March 26, 2026 09:12

Atualizando o topico History com informações de meu fork

374a9fc

Atualizando Registry e codigos das novas variáveis diagnosticas

4729442

Adiciona variável Surface CAPE & CIN

e93cfeb

Updated with Merge upstream/develop

9db6f55

joaomas self-requested a review April 1, 2026 17:30

joaomas requested changes Apr 14, 2026

View reviewed changes

Fix bug em mpas_stability_indices.F

3b68d3b

joaomas changed the base branch from develop to prod June 2, 2026 15:04

joaomas added the MONAN - prod (diptc) label Jun 26, 2026

Fix bug and undef values

d97366c

joaomas reviewed Jul 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Nova variáveis para OPER#28

Nova variáveis para OPER#28
jpablofernandez wants to merge 6 commits into
monanadmin:prodfrom
jpablofernandez:develop

jpablofernandez commented Apr 1, 2026

Uh oh!

joaomas commented Apr 8, 2026 •

edited

Loading

Uh oh!

joaomas left a comment

Uh oh!

joaomas Apr 14, 2026

Uh oh!

joaomas left a comment

Uh oh!

joaomas Apr 14, 2026

Uh oh!

joaomas commented Apr 22, 2026

Uh oh!

joaomas Jul 10, 2026 •

edited

Loading

Uh oh!

joaomas Jul 10, 2026 •

edited

Loading

Uh oh!

joaomas Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jpablofernandez commented Apr 1, 2026

Pull Request Description

Type of Change

Testing and Quality

Scientific Impact

Uh oh!

joaomas commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaomas left a comment

Choose a reason for hiding this comment

Uh oh!

joaomas Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

joaomas left a comment

Choose a reason for hiding this comment

Uh oh!

joaomas Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

joaomas commented Apr 22, 2026

Uh oh!

joaomas Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joaomas Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joaomas Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

joaomas commented Apr 8, 2026 •

edited

Loading

joaomas Jul 10, 2026 •

edited

Loading

joaomas Jul 10, 2026 •

edited

Loading