Skip to content
This repository was archived by the owner on Nov 26, 2024. It is now read-only.

Update Inferno to newer version#5

Open
trueadm wants to merge 5 commits into
monkberry:gh-pagesfrom
trueadm:gh-pages
Open

Update Inferno to newer version#5
trueadm wants to merge 5 commits into
monkberry:gh-pagesfrom
trueadm:gh-pages

Conversation

@trueadm

@trueadm trueadm commented Sep 9, 2016

Copy link
Copy Markdown
Contributor

Updated Inferno version to 1.0-alpha3, along with babel-plugin-inferno to 1.0-alpha4. Inferno 1.0 is a lot faster than 0.7, which was the version previously used.

@antonmedv

Copy link
Copy Markdown
Member

A lot of childrenType. What it's doing?
From where your giant so performant?

@antonmedv

Copy link
Copy Markdown
Member

Got this when trying to build:

ERROR in ./template.inferno.js
Module build failed: SyntaxError: Unexpected token {

@trueadm

trueadm commented Sep 10, 2016

Copy link
Copy Markdown
Contributor Author

@Elfet Strange, I don't seem to get that error. Is it when building ticket-rendering? The childrenTypes are type info that Inferno uses to skip validation checks. Most of them will be removed once Inferno Babel plugin is complete, but currently it's in alpha :)

@antonmedv

Copy link
Copy Markdown
Member

In ticket-rendering. Fresh clone, npm i. :)

@trueadm

trueadm commented Sep 10, 2016

Copy link
Copy Markdown
Contributor Author

@Elfet I still don't have any issues. Make sure you have node v6.4.

@antonmedv

Copy link
Copy Markdown
Member

4.5.10 сент. 2016 г., в 14:43, Dominic Gannaway notifications@github.com написал(а):@Elfet I still don't have any issues. Make sure you have node v6.4.—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/monkberry/benchmark","title":"monkberry/benchmark","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/monkberry/benchmark"}},"updates":{"snippets":[{"icon":"PERSON","message":"@trueadm in #5: @Elfet I still don't have any issues. Make sure you have node v6.4."}],"action":{"name":"View Pull Request","url":"#5 (comment)"}}}

@trueadm

trueadm commented Sep 10, 2016

Copy link
Copy Markdown
Contributor Author

Actually, I was right the first time. You'll need node v6+, I just tried node 4 and I get the same error.

@trueadm

trueadm commented Sep 10, 2016

Copy link
Copy Markdown
Contributor Author

@Elfet Any luck getting it working?

@trueadm

trueadm commented Sep 10, 2016

Copy link
Copy Markdown
Contributor Author

@Elfet I've pushed some changes, that should hopefully fix your problem.

@antonmedv

Copy link
Copy Markdown
Member

Still falling on stable 4.5.0, but okay on 6.5.0.

@trueadm

trueadm commented Sep 12, 2016

Copy link
Copy Markdown
Contributor Author

@Elfet Awesome. Glad you got it working. Are you going to merge?

@antonmedv

Copy link
Copy Markdown
Member

Yes, i'm going to merge. But it will be better if it will be possible to build in on stable version of node.
Also it's only tickets-render?

@trueadm

trueadm commented Sep 12, 2016

Copy link
Copy Markdown
Contributor Author

@Elfet I can see todos in the commits too?

@antonmedv

Copy link
Copy Markdown
Member

Todos in commits? Sorry, does not understand you:(

@trueadm

trueadm commented Sep 15, 2016

Copy link
Copy Markdown
Contributor Author

@Elfet I don't understand what the issue is with the PR? the todos benchmark is also in this PR?

@antonmedv

Copy link
Copy Markdown
Member

Every think is okay. I just was thinking what you are going to make possible to build bundle on stable node 4.5?

@antonmedv

Copy link
Copy Markdown
Member

@trueadm can you also update single-point benchmark to new inferno?

@trueadm

trueadm commented Sep 17, 2016

Copy link
Copy Markdown
Contributor Author

@Elfet done :)

@antonmedv

Copy link
Copy Markdown
Member

Now got this:

npm ERR! version not found: inferno@1.0.0-alpha9

😞

@trueadm

trueadm commented Sep 19, 2016

Copy link
Copy Markdown
Contributor Author

This is an NPM bug unfortunately. You need to manually do 'npm install --save inferno@alpha11' in the relevant directories and it will work. I'm going to raise an issue at NPM about it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants