Skip to content

fix: resolve sort comparator and code quality issues (@ennajari) #7805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ennajari wants to merge 9 commits into
base: master
Choose a base branch
from
+2 −2
Open

fix: resolve sort comparator and code quality issues (@ennajari) #7805

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c8ea9f6
fix: resolve sort comparator and code quality issues
ennajari Apr 10, 2026
faa7bc4
fix: apply prettier formatting
ennajari Apr 10, 2026
0ef75ea
fix: address review feedback
ennajari Apr 10, 2026
536aa2c
fix: use locale-independent sort comparator
ennajari Apr 10, 2026
dffb721
sonar-scanner
ennajari Apr 11, 2026
c12b956
Revert "sonar-scanner"
ennajari Apr 11, 2026
555b3f5
fix: revert sort comparator to plain .sort() per review
ennajari Apr 11, 2026
f469b6c
Merge branch 'master' into fix/sort-comparator-and-code-quality
ennajari Apr 13, 2026
f963dda
fix: revert reduce initial value per review
ennajari Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,4 +132,4 @@ frontend/static/webfonts-preview
.turbo
frontend/.env.sentry-build-plugin
.claude/worktrees
1024MiB
1024MiB
2 changes: 1 addition & 1 deletion frontend/src/ts/utils/json-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export function memoizeAsync<P, Args extends unknown[], R>(
const key = getKey ? getKey(...args) : (args[0] as P);

const cached = cache.get(key);
if (cached) {
if (cached !== undefined) {
return cached;
}

Expand Down
3 changes: 2 additions & 1 deletion packages/util/src/numbers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ export function stdDev(array: number[]): number {
const n = array.length;
const meanValue = mean(array);
return Math.sqrt(
array.map((x) => Math.pow(x - meanValue, 2)).reduce((a, b) => a + b) / n,
array.map((x) => Math.pow(x - meanValue, 2)).reduce((a, b) => a + b, 0) /
Copy link
Copy Markdown
Contributor

@nadalaba nadalaba Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed. reduce((a, b) => a + b) is a known summing pattern

Copy link
Copy Markdown
Author

@ennajari ennajari Apr 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the surrounding try/catch already returns 0 if the array is empty, so the initial value has no effect. I'll revert this.

n,
);
} catch (e) {
return 0;
Expand Down
Loading