Skip to content

perf: avoid redundant character counting in test stats calculation (@rohanghosal04) #8080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohanghosal04 wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −3
Open

perf: avoid redundant character counting in test stats calculation (@rohanghosal04) #8080

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54d628f
perf: avoid redundant character counting in test stats calculation (@…
rohanghosal04 Jun 10, 2026
cab7557
style: fix indentation on line 1
rohanghosal04 Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/src/ts/test/test-stats.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ export function calculateWpmAndRaw(
withDecimalPoints?: true,
final = false,
testSecondsOverride?: number,
charsOverride?: CharCount,
): {
wpm: number;
raw: number;
Expand All @@ -124,7 +125,7 @@ export function calculateWpmAndRaw(
testSecondsOverride ??
calculateTestSeconds(TestState.isActive ? performance.now() : end);

const chars = countChars(final);
const chars = charsOverride ?? countChars(final);
const wpm = Numbers.roundTo2(
(chars.correctWordChars * (60 / testSeconds)) / 5,
);
Expand Down Expand Up @@ -341,9 +342,8 @@ export function calculateFinalStats(): Stats {
);
}

//todo: this counts chars twice - once here and once in calculateWpmAndRaw
const chars = countChars(true);
const { wpm, raw } = calculateWpmAndRaw(true, true, testSeconds);
const { wpm, raw } = calculateWpmAndRaw(true, true, testSeconds, chars);
const acc = Numbers.roundTo2(calculateAccuracy());
const ret = {
wpm: isNaN(wpm) ? 0 : wpm,
Expand Down
Loading