Fixes #1830 Merge v1.3.2-rc.1 into develop for artifactory#1169
Closed
GOKULRAJ136 wants to merge 3 commits into
Closed
Fixes #1830 Merge v1.3.2-rc.1 into develop for artifactory#1169GOKULRAJ136 wants to merge 3 commits into
GOKULRAJ136 wants to merge 3 commits into
Conversation
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
WalkthroughThis PR consolidates infrastructure, build, deployment, and internationalization updates across the MOSIP artifactory reference implementation. It updates project documentation and licensing, bumps Maven dependencies, reconfigures Kubernetes/Helm defaults, refactors i18n content across eSignet and partner bundles while removing legacy IDP and resident translation files, and restructures theme variables. ChangesRepository Infrastructure & Internationalization Consolidation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (4)
artifacts/src/i18n/pmp-entity-spec-bundle/entity-spec/policy-mapping.json (1)
126-126:⚠️ Potential issue | 🟠 Major | ⚡ Quick winMajor: Tamil text in Arabic translation field.
Line 126 contains Tamil text (
"கூட்டாளர் பெயர்") in the Arabic ("ara") field. This should contain Arabic text for "Partner Name".🔧 Proposed fix
"label": { "eng": "Partner Name", - "ara": "கூட்டாளர் பெயர்", + "ara": "اسم شريك", "fra": "Nom du partenaire",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@artifacts/src/i18n/pmp-entity-spec-bundle/entity-spec/policy-mapping.json` at line 126, The "ara" JSON translation value currently contains Tamil text ("கூட்டாளர் பெயர்"); replace that value with the correct Arabic translation for "Partner Name" (e.g., "اسم الشريك") by updating the "ara" field in the policy-mapping.json entity-spec entry so the Arabic key "ara" holds the Arabic string instead of the Tamil one.artifacts/src/i18n/mock-relying-party-i18n-bundle/ta.json (1)
166-166:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winCritical: Inconsistent translation key across language files.
This file uses
"error"(singular) at line 166, while other language files (en.json, hi.json, km.json, ar.json) use"errors"(plural). This structural inconsistency will cause runtime failures when loading translations.🔧 Proposed fix
- "error": { + "errors": { "sign_in_failed": "அங்கீகரிப்பு தோல்வியுற்றது! eSignet மூலம் உள்நுழைய முயற்சிக்கவும்",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@artifacts/src/i18n/mock-relying-party-i18n-bundle/ta.json` at line 166, The translation bundle ta.json has a mismatched top-level key "error" (singular) at the shown diff while all other locales use "errors" (plural); rename the key "error" to "errors" in ta.json to match the structure used by en.json/hi.json/km.json/ar.json so the i18n loader finds the same object shape at runtime and remove any duplicate/conflicting "errors" entries if present.artifacts/src/i18n/mock-relying-party-i18n-bundle/kn.json (1)
166-166:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winCritical: Align translation key spelling in kn locale (
"error"vs"errors")
artifacts/src/i18n/mock-relying-party-i18n-bundle/kn.jsondefines the key as"error"(line 166). The mock relying-party bundles must share an identical key structure to avoid lookup failures for this locale—confirm the expected key name (e.g.,"errors") and update if needed.🔧 Proposed fix
- "error": { + "errors": { "sign_in_failed": "ಪ್ರಮಾಣೀಕರಣ ವಿಫಲವಾಗಿದೆ! ಇಸಿಗ್ನೆಟ್ ಮೂಲಕ ಸೈನ್ ಇನ್ ಮಾಡಲು ಪ್ರಯತ್ನಿಸಿ",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@artifacts/src/i18n/mock-relying-party-i18n-bundle/kn.json` at line 166, The kn locale JSON uses the top-level key "error" but the mock relying-party bundles expect the key "errors"; rename the key "error" to "errors" in the kn.json bundle and ensure its nested structure and child keys exactly match the other locale bundles (same keys/phrasing under "errors") so lookup calls that reference "errors" will succeed; if instead the canonical key is "error" update other bundles/code to match, but keep the key name consistent across all mock relying-party bundles.artifacts/src/i18n/pmp-i18n-bundle/i18n/eng.json (1)
444-459:⚠️ Potential issue | 🟠 Major | ⚡ Quick winRemove the duplicate
filterskey to avoid silent override.Line 444 defines
filters, and Line 452 definesfiltersagain. In JSON, the later key wins, so the updated"Map Policy Group"/"Save"strings are ignored.💡 Proposed fix
- "filters": { - "titleTxt": "Add Filters", - "footerButtons": { - "resetTxt": "Reset", - "cancelTxt": "Cancel", - "applyTxt": "Apply" - } - },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@artifacts/src/i18n/pmp-i18n-bundle/i18n/eng.json` around lines 444 - 459, There are two duplicate top-level "filters" objects causing the second to override the first; merge them into a single "filters" object so both "titleTxt" and the "footerButtons" entries are preserved (ensure "titleTxt" uses the intended value "Map Policy Group" if that is desired, and the "applyTxt" uses "Save" accordingly), removing the duplicate key and combining or deduplicating nested keys like "resetTxt", "cancelTxt", and "applyTxt" so no values are silently lost.
🧹 Nitpick comments (1)
artifacts/build_version.sh (1)
11-48: ⚡ Quick winConsider adding error handling for failed artifact lookups.
The script silently continues if any
curlcommand fails or if an artifact is not found in the repository. This makes it difficult to diagnose issues when snapshot artifacts are missing.♻️ Proposed enhancement to add error checking
echo timestamp for auth adapter. -curl -s https://central.sonatype.com/repository/maven-snapshots/io/mosip/kernel/kernel-auth-adapter/$version/maven-metadata.xml | grep value | sed "s/.*<value>\([^<]*\)<\/value>.*/\1/" | sed -n '1p' +timestamp=$(curl -s https://central.sonatype.com/repository/maven-snapshots/io/mosip/kernel/kernel-auth-adapter/$version/maven-metadata.xml | grep value | sed "s/.*<value>\([^<]*\)<\/value>.*/\1/" | sed -n '1p') +if [ -z "$timestamp" ]; then + echo "ERROR: Failed to fetch timestamp for kernel-auth-adapter" +else + echo "$timestamp" +fiApply similar pattern to other artifact lookups.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@artifacts/build_version.sh` around lines 11 - 48, The script currently runs many curl commands for Maven metadata (e.g., the curl lines retrieving maven-metadata.xml for artifacts using $version, ${idp_auth_wrapper_version}, ${esignet_auth_wrapper_version}) but ignores failures; update each artifact lookup to detect curl failure or missing <value> (empty output) and handle it: run curl with --fail -s (or check its exit status), capture the parsed timestamp into a variable, test that the variable is non-empty, and if curl failed or the value is empty log a clear error message to stderr and exit non‑zero (or optionally continue with a consistent warning) so missing snapshots are hard-failed and diagnosable. Ensure you apply the same pattern to every curl + grep/sed pipeline in the script.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/tag.yml:
- Around line 17-18: The workflow input defaults currently use unquoted
Python-style booleans (e.g., default: False) which is invalid for GitHub
Actions; update the workflow_dispatch input default values to lowercase quoted
strings (e.g., default: 'false' or default: 'true') for every input that
currently uses False/True (including the other occurrence noted), keeping
required: true and type: string intact so the inputs parse correctly.
In `@artifacts/pom.xml`:
- Around line 48-50: The pom defines a snapshot repo with id
"sonatype-central-snapshots" and URL
"https://central.sonatype.com/repository/maven-snapshots"; fix the 403 by
ensuring your Maven settings.xml contains a <server> entry whose <id> exactly
matches "sonatype-central-snapshots" and contains the Central Portal
token/credentials, and confirm in the Sonatype Central Portal that SNAPSHOT
publishing/access is enabled for your namespace (do not rely on old OSSRH
credentials).
In `@artifacts/src/i18n/esignet-signup-i18n-bundle/en.json`:
- Around line 139-141: Update the production user-facing strings by removing the
testing wording: change the "header" value (currently "Terms & Conditions for
testing") to a standard production phrase like "Terms & Conditions", and fix the
"agree_text" string to remove typos ("conditionditions") and ensure it reads
correctly (e.g., "I have read and understood the terms and conditions and agree
to the terms and conditions as set out by the user agreement."); modify the JSON
entries for "header" and "agree_text" accordingly.
- Around line 161-184: The strings under the ekycSteps bundle contain multiple
"testing" references that must be removed or rephrased for production; update
the values for keys ekycSteps.ekyc_provider.label and .description,
ekycSteps.terms_&_conditions.label and .description,
ekycSteps.pre_verification_guide.label and .description,
ekycSteps.identity_verification.label and .description, and
ekycSteps.review_consent.label and .description (and optionally header) to
remove the word "testing" and use neutral production wording such as "Select
your eKYC provider", "Terms & Conditions", "Pre-verification guide", "Identity
verification", and "Review consent" with concise descriptions that don’t mention
testing.
In `@artifacts/src/i18n/pmp-entity-spec-bundle/entity-spec/policy-mapping.json`:
- Line 228: The English label for the policyName filter is incorrect: change the
JSON value for the policyName filter's "eng" property from "Partner Name" to
"Policy Name" in the policy-mapping JSON (search for the policyName entry and
update its "eng" field), so the UI displays the correct English label for the
policyName filter.
In `@NOTICE`:
- Around line 36-37: Update the NOTICE reference from the incorrect `license/`
path to the actual `licenses/` directory added by this PR by replacing the
string "license/" with "licenses/" in the NOTICE text so the legal pointer
matches the repository's `licenses/` folder.
In `@README.md`:
- Around line 34-36: Update the Markdown fenced command blocks in README.md to
declare a shell language (use ```sh) and remove any leading shell prompt markers
($) so they are plain command lines; specifically change the blocks containing
"export KUBECONFIG=~/.kube/<my-cluster.config>" and the blocks that run "cd
deploy" and "./install.sh", "./delete.sh", "./restart.sh" to use ```sh and
unprefixed commands so the snippets are lint-clean and copy/paste friendly.
- Around line 27-30: Remove the duplicated sentence "All these artifacts are
released as a part of the Mosip Release with some of them being taken from open
sourced repository as per the need." by deleting the second occurrence so only a
single instance remains in the README section; ensure surrounding paragraph
spacing remains correct and no other sentences were unintentionally altered.
In `@THIRD-PARTY-NOTICES.txt`:
- Line 40: Update the incorrect directory reference in the
THIRD-PARTY-NOTICES.txt text: change the string "license/ directory" to
"licenses/ directory" so it matches the actual directory name used in the repo;
locate the sentence containing "Full license texts and additional details ...
license/ directory" and replace "license/" with "licenses/".
---
Outside diff comments:
In `@artifacts/src/i18n/mock-relying-party-i18n-bundle/kn.json`:
- Line 166: The kn locale JSON uses the top-level key "error" but the mock
relying-party bundles expect the key "errors"; rename the key "error" to
"errors" in the kn.json bundle and ensure its nested structure and child keys
exactly match the other locale bundles (same keys/phrasing under "errors") so
lookup calls that reference "errors" will succeed; if instead the canonical key
is "error" update other bundles/code to match, but keep the key name consistent
across all mock relying-party bundles.
In `@artifacts/src/i18n/mock-relying-party-i18n-bundle/ta.json`:
- Line 166: The translation bundle ta.json has a mismatched top-level key
"error" (singular) at the shown diff while all other locales use "errors"
(plural); rename the key "error" to "errors" in ta.json to match the structure
used by en.json/hi.json/km.json/ar.json so the i18n loader finds the same object
shape at runtime and remove any duplicate/conflicting "errors" entries if
present.
In `@artifacts/src/i18n/pmp-entity-spec-bundle/entity-spec/policy-mapping.json`:
- Line 126: The "ara" JSON translation value currently contains Tamil text
("கூட்டாளர் பெயர்"); replace that value with the correct Arabic translation for
"Partner Name" (e.g., "اسم الشريك") by updating the "ara" field in the
policy-mapping.json entity-spec entry so the Arabic key "ara" holds the Arabic
string instead of the Tamil one.
In `@artifacts/src/i18n/pmp-i18n-bundle/i18n/eng.json`:
- Around line 444-459: There are two duplicate top-level "filters" objects
causing the second to override the first; merge them into a single "filters"
object so both "titleTxt" and the "footerButtons" entries are preserved (ensure
"titleTxt" uses the intended value "Map Policy Group" if that is desired, and
the "applyTxt" uses "Save" accordingly), removing the duplicate key and
combining or deduplicating nested keys like "resetTxt", "cancelTxt", and
"applyTxt" so no values are silently lost.
---
Nitpick comments:
In `@artifacts/build_version.sh`:
- Around line 11-48: The script currently runs many curl commands for Maven
metadata (e.g., the curl lines retrieving maven-metadata.xml for artifacts using
$version, ${idp_auth_wrapper_version}, ${esignet_auth_wrapper_version}) but
ignores failures; update each artifact lookup to detect curl failure or missing
<value> (empty output) and handle it: run curl with --fail -s (or check its exit
status), capture the parsed timestamp into a variable, test that the variable is
non-empty, and if curl failed or the value is empty log a clear error message to
stderr and exit non‑zero (or optionally continue with a consistent warning) so
missing snapshots are hard-failed and diagnosable. Ensure you apply the same
pattern to every curl + grep/sed pipeline in the script.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 07378964-fcef-42e3-a792-b41f429d75cc
⛔ Files ignored due to path filters (3)
artifacts/src/hsm/client.zipis excluded by!**/*.zipartifacts/src/jre/zulu11.41.23-ca-fx-jre11.0.8-win_x64.zipis excluded by!**/*.zipartifacts/src/master-templates/machine_type.csvis excluded by!**/*.csv
📒 Files selected for processing (69)
.github/workflows/tag.ymlAGENTS.mdLICENSE.txtNOTICEREADME.mdTHIRD-PARTY-NOTICES.txtartifacts/Dockerfileartifacts/build_version.shartifacts/configure.shartifacts/pom.xmlartifacts/src/i18n/admin-entity-spec-bundle/entity-spec/dynamicfields.jsonartifacts/src/i18n/admin-entity-spec-bundle/entity-spec/templates.jsonartifacts/src/i18n/esignet-i18n-bundle/ar.jsonartifacts/src/i18n/esignet-i18n-bundle/default.jsonartifacts/src/i18n/esignet-i18n-bundle/en.jsonartifacts/src/i18n/esignet-i18n-bundle/hi.jsonartifacts/src/i18n/esignet-i18n-bundle/km.jsonartifacts/src/i18n/esignet-i18n-bundle/kn.jsonartifacts/src/i18n/esignet-i18n-bundle/ta.jsonartifacts/src/i18n/esignet-signup-i18n-bundle/default.jsonartifacts/src/i18n/esignet-signup-i18n-bundle/en.jsonartifacts/src/i18n/esignet-signup-i18n-bundle/km.jsonartifacts/src/i18n/idp-i18n-bundle/ar.jsonartifacts/src/i18n/idp-i18n-bundle/ara.jsonartifacts/src/i18n/idp-i18n-bundle/default.jsonartifacts/src/i18n/idp-i18n-bundle/en.jsonartifacts/src/i18n/idp-i18n-bundle/eng.jsonartifacts/src/i18n/idp-i18n-bundle/hi.jsonartifacts/src/i18n/idp-i18n-bundle/hin.jsonartifacts/src/i18n/idp-i18n-bundle/kan.jsonartifacts/src/i18n/idp-i18n-bundle/kn.jsonartifacts/src/i18n/idp-i18n-bundle/ta.jsonartifacts/src/i18n/idp-i18n-bundle/tam.jsonartifacts/src/i18n/mock-relying-party-i18n-bundle/ar.jsonartifacts/src/i18n/mock-relying-party-i18n-bundle/en.jsonartifacts/src/i18n/mock-relying-party-i18n-bundle/hi.jsonartifacts/src/i18n/mock-relying-party-i18n-bundle/km.jsonartifacts/src/i18n/mock-relying-party-i18n-bundle/kn.jsonartifacts/src/i18n/mock-relying-party-i18n-bundle/ta.jsonartifacts/src/i18n/pmp-entity-spec-bundle/entity-spec/policy-mapping.jsonartifacts/src/i18n/pmp-i18n-bundle/i18n/ara.jsonartifacts/src/i18n/pmp-i18n-bundle/i18n/eng.jsonartifacts/src/i18n/pmp-i18n-bundle/i18n/fra.jsonartifacts/src/i18n/pmp-i18n-bundle/i18n/hin.jsonartifacts/src/i18n/pmp-i18n-bundle/i18n/kan.jsonartifacts/src/i18n/pmp-i18n-bundle/i18n/tam.jsonartifacts/src/i18n/pre-registration-i18n-bundle/i18n/ara.jsonartifacts/src/i18n/pre-registration-i18n-bundle/i18n/eng.jsonartifacts/src/i18n/pre-registration-i18n-bundle/i18n/fra.jsonartifacts/src/i18n/pre-registration-i18n-bundle/i18n/hin.jsonartifacts/src/i18n/pre-registration-i18n-bundle/i18n/kan.jsonartifacts/src/i18n/pre-registration-i18n-bundle/i18n/tam.jsonartifacts/src/i18n/resident-i18n-bundle/ara.jsonartifacts/src/i18n/resident-i18n-bundle/default.jsonartifacts/src/i18n/resident-i18n-bundle/eng.jsonartifacts/src/i18n/resident-i18n-bundle/fra.jsonartifacts/src/i18n/resident-i18n-bundle/hin.jsonartifacts/src/i18n/resident-i18n-bundle/kan.jsonartifacts/src/i18n/resident-i18n-bundle/spa.jsonartifacts/src/i18n/resident-i18n-bundle/tam.jsonartifacts/src/theme/esignet-signup-theme/variables.cssartifacts/src/theme/esignet-theme/variables.csshelm/artifactory/.gitignorehelm/artifactory/templates/deployment.yamlhelm/artifactory/values.yamllicenses/Apache-2.0.txtlicenses/MIT.txtlicenses/MPL-2.0.txtlicenses/NOTICE
💤 Files with no reviewable changes (19)
- artifacts/src/i18n/idp-i18n-bundle/tam.json
- artifacts/src/i18n/idp-i18n-bundle/default.json
- artifacts/src/i18n/idp-i18n-bundle/hi.json
- artifacts/src/i18n/resident-i18n-bundle/fra.json
- artifacts/src/i18n/resident-i18n-bundle/spa.json
- artifacts/src/i18n/idp-i18n-bundle/hin.json
- artifacts/src/i18n/idp-i18n-bundle/ar.json
- artifacts/src/i18n/idp-i18n-bundle/eng.json
- artifacts/src/i18n/idp-i18n-bundle/ara.json
- artifacts/src/i18n/idp-i18n-bundle/kn.json
- artifacts/src/i18n/resident-i18n-bundle/ara.json
- artifacts/src/i18n/idp-i18n-bundle/ta.json
- artifacts/src/i18n/idp-i18n-bundle/kan.json
- artifacts/src/i18n/resident-i18n-bundle/kan.json
- artifacts/src/i18n/idp-i18n-bundle/en.json
- artifacts/src/i18n/resident-i18n-bundle/hin.json
- artifacts/src/i18n/resident-i18n-bundle/default.json
- artifacts/src/i18n/resident-i18n-bundle/tam.json
- artifacts/src/i18n/resident-i18n-bundle/eng.json
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
Documentation
Chores
Bug Fixes