Skip to content

#1830 Update dependency versions in pom.xml#1107

Merged
ashok-ksharma merged 3 commits into
mosip:developfrom
GOKULRAJ136:dev-snap
Jun 8, 2026
Merged

#1830 Update dependency versions in pom.xml#1107
ashok-ksharma merged 3 commits into
mosip:developfrom
GOKULRAJ136:dev-snap

Conversation

@GOKULRAJ136

@GOKULRAJ136 GOKULRAJ136 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated build dependency versions across multiple modules from snapshot to release candidate versions, aligning the system to use stable kernel and core library versions.

Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

This pull request downgrades Maven version properties across the MOSIP reference implementation from 1.4.0-SNAPSHOT to 1.3.1-rc.1 (with pre-registration core downgrading to 1.3.0). The change affects kernel core, kernel BOM, logging, and SMS provider dependencies, propagating through cache providers and service modules.

Changes

Maven Version Alignment

Layer / File(s) Summary
Kernel base version properties
kernel/pom.xml, kernel/kernel-smsserviceprovider-msg91/pom.xml
Core kernel version properties (kernel-core.version, kernel.core.version, kernel.auth.adaptor.version) are downgraded from 1.4.0-SNAPSHOT to 1.3.1-rc.1.
Cache provider and logging BOM versions
cache-provider-hazelcast/pom.xml, cache-provider-redis/pom.xml, kernel/kernel-ref-idobjectvalidator/pom.xml
Kernel BOM and logging library versions are downgraded to 1.3.1-rc.1 in cache provider modules and the ID validator, which reference the kernel base properties.
Service module parent and dependency versions
pre-registration-booking-service/pom.xml, registration-processor/registration-processor-external-integration-service/pom.xml, registration-processor/registration-processor-external-stage/pom.xml
Registration processor and pre-registration service modules update parent POM versions and dependency properties; pre-registration core is set to 1.3.0 while kernel dependencies align to 1.3.1-rc.1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A version change sweeps through the land so fair,
From snapshot dreams to release in the air,
One-point-three-one-rc takes the crown,
Downgrading versions all through town,
Maven properties now in harmony bind.
🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating dependency versions across multiple pom.xml files in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
kernel/kernel-ref-idobjectvalidator/pom.xml (1)

4-8: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Parent version remains 1.4.0-SNAPSHOT while dependencies downgrade.

This module inherits from kernel-ref-parent:1.4.0-SNAPSHOT (lines 4-8) but overrides dependency versions to 1.3.1-rc.1 (lines 15-16). Additionally, line 43 references ${kernel-core.version}, which is inherited from the parent POM that was updated to 1.3.1-rc.1 in kernel/pom.xml.

This creates a mixed-version build where the module's parent and artifact version are 1.4.0-SNAPSHOT, but its dependencies are at 1.3.1-rc.1. Verify this is the intended behavior and won't cause issues during Maven's dependency resolution.

Also applies to: 15-16

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@kernel/kernel-ref-idobjectvalidator/pom.xml` around lines 4 - 8, The pom
declares a parent <parent> kernel-ref-parent with version 1.4.0-SNAPSHOT while
several dependency properties (e.g., lines setting kernel-core.version /
overridden dependencies to 1.3.1-rc.1) create a mixed-version build; either
align the parent version to 1.3.1-rc.1 or bump the overridden dependency
properties (such as ${kernel-core.version} and the explicit kernel dependency
versions) to 1.4.0-SNAPSHOT so the module and its parent/dependencies are
consistent—update the <parent> version or the property values in this POM
(references: kernel-ref-parent, ${kernel-core.version}) accordingly and run mvn
dependency:tree to verify no cross-version conflicts.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@kernel/pom.xml`:
- Line 90: Confirm that the specified dependency version exists and then run the
module build: verify that io.mosip.kernel:kernel-core:1.3.1-rc.1 is resolvable
from Maven Central (it should be, per the review) and then execute a full build
of the kernel and all modules that depend on kernel-core (e.g., run mvn -U clean
install on the kernel and the kernel-dependent modules) to ensure the downgrade
to <kernel-core.version>1.3.1-rc.1</kernel-core.version> does not break any
consumers; if any module fails, update that module's code or dependency
constraints to be compatible with kernel-core 1.3.1-rc.1.

In `@pre-registration-booking-service/pom.xml`:
- Line 427: The pom specifies kernel-auth-adapter version 1.3.1 inside the
openapi-doc-generate-profile while other kernel artifacts use 1.3.1-rc.1; verify
this is intentional and that kernel-auth-adapter:1.3.1 is binary-compatible with
kernel-core:1.3.1-rc.1—if not intentional, align the versions by changing
kernel-auth-adapter to 1.3.1-rc.1 (or upgrade all kernel dependencies to 1.3.1),
or add a comment/rollback note in the openapi-doc-generate-profile clarifying
why kernel-auth-adapter remains at 1.3.1; check compatibility by running the
project build and relevant integration tests referencing kernel-core and
kernel-auth-adapter.

---

Outside diff comments:
In `@kernel/kernel-ref-idobjectvalidator/pom.xml`:
- Around line 4-8: The pom declares a parent <parent> kernel-ref-parent with
version 1.4.0-SNAPSHOT while several dependency properties (e.g., lines setting
kernel-core.version / overridden dependencies to 1.3.1-rc.1) create a
mixed-version build; either align the parent version to 1.3.1-rc.1 or bump the
overridden dependency properties (such as ${kernel-core.version} and the
explicit kernel dependency versions) to 1.4.0-SNAPSHOT so the module and its
parent/dependencies are consistent—update the <parent> version or the property
values in this POM (references: kernel-ref-parent, ${kernel-core.version})
accordingly and run mvn dependency:tree to verify no cross-version conflicts.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 143213c3-860f-42f8-acbe-2d138642c0a2

📥 Commits

Reviewing files that changed from the base of the PR and between 799e364 and efaaa3e.

📒 Files selected for processing (8)
  • cache-provider-hazelcast/pom.xml
  • cache-provider-redis/pom.xml
  • kernel/kernel-ref-idobjectvalidator/pom.xml
  • kernel/kernel-smsserviceprovider-msg91/pom.xml
  • kernel/pom.xml
  • pre-registration-booking-service/pom.xml
  • registration-processor/registration-processor-external-integration-service/pom.xml
  • registration-processor/registration-processor-external-stage/pom.xml

Comment thread kernel/pom.xml
Comment thread pre-registration-booking-service/pom.xml
@ashok-ksharma ashok-ksharma merged commit 31b7f79 into mosip:develop Jun 8, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants