#1830 Update dependency versions in pom.xml#1107
Conversation
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
WalkthroughThis pull request downgrades Maven version properties across the MOSIP reference implementation from ChangesMaven Version Alignment
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
kernel/kernel-ref-idobjectvalidator/pom.xml (1)
4-8:⚠️ Potential issue | 🟠 Major | ⚡ Quick winParent version remains 1.4.0-SNAPSHOT while dependencies downgrade.
This module inherits from
kernel-ref-parent:1.4.0-SNAPSHOT(lines 4-8) but overrides dependency versions to1.3.1-rc.1(lines 15-16). Additionally, line 43 references${kernel-core.version}, which is inherited from the parent POM that was updated to1.3.1-rc.1inkernel/pom.xml.This creates a mixed-version build where the module's parent and artifact version are
1.4.0-SNAPSHOT, but its dependencies are at1.3.1-rc.1. Verify this is the intended behavior and won't cause issues during Maven's dependency resolution.Also applies to: 15-16
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@kernel/kernel-ref-idobjectvalidator/pom.xml` around lines 4 - 8, The pom declares a parent <parent> kernel-ref-parent with version 1.4.0-SNAPSHOT while several dependency properties (e.g., lines setting kernel-core.version / overridden dependencies to 1.3.1-rc.1) create a mixed-version build; either align the parent version to 1.3.1-rc.1 or bump the overridden dependency properties (such as ${kernel-core.version} and the explicit kernel dependency versions) to 1.4.0-SNAPSHOT so the module and its parent/dependencies are consistent—update the <parent> version or the property values in this POM (references: kernel-ref-parent, ${kernel-core.version}) accordingly and run mvn dependency:tree to verify no cross-version conflicts.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@kernel/pom.xml`:
- Line 90: Confirm that the specified dependency version exists and then run the
module build: verify that io.mosip.kernel:kernel-core:1.3.1-rc.1 is resolvable
from Maven Central (it should be, per the review) and then execute a full build
of the kernel and all modules that depend on kernel-core (e.g., run mvn -U clean
install on the kernel and the kernel-dependent modules) to ensure the downgrade
to <kernel-core.version>1.3.1-rc.1</kernel-core.version> does not break any
consumers; if any module fails, update that module's code or dependency
constraints to be compatible with kernel-core 1.3.1-rc.1.
In `@pre-registration-booking-service/pom.xml`:
- Line 427: The pom specifies kernel-auth-adapter version 1.3.1 inside the
openapi-doc-generate-profile while other kernel artifacts use 1.3.1-rc.1; verify
this is intentional and that kernel-auth-adapter:1.3.1 is binary-compatible with
kernel-core:1.3.1-rc.1—if not intentional, align the versions by changing
kernel-auth-adapter to 1.3.1-rc.1 (or upgrade all kernel dependencies to 1.3.1),
or add a comment/rollback note in the openapi-doc-generate-profile clarifying
why kernel-auth-adapter remains at 1.3.1; check compatibility by running the
project build and relevant integration tests referencing kernel-core and
kernel-auth-adapter.
---
Outside diff comments:
In `@kernel/kernel-ref-idobjectvalidator/pom.xml`:
- Around line 4-8: The pom declares a parent <parent> kernel-ref-parent with
version 1.4.0-SNAPSHOT while several dependency properties (e.g., lines setting
kernel-core.version / overridden dependencies to 1.3.1-rc.1) create a
mixed-version build; either align the parent version to 1.3.1-rc.1 or bump the
overridden dependency properties (such as ${kernel-core.version} and the
explicit kernel dependency versions) to 1.4.0-SNAPSHOT so the module and its
parent/dependencies are consistent—update the <parent> version or the property
values in this POM (references: kernel-ref-parent, ${kernel-core.version})
accordingly and run mvn dependency:tree to verify no cross-version conflicts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 143213c3-860f-42f8-acbe-2d138642c0a2
📒 Files selected for processing (8)
cache-provider-hazelcast/pom.xmlcache-provider-redis/pom.xmlkernel/kernel-ref-idobjectvalidator/pom.xmlkernel/kernel-smsserviceprovider-msg91/pom.xmlkernel/pom.xmlpre-registration-booking-service/pom.xmlregistration-processor/registration-processor-external-integration-service/pom.xmlregistration-processor/registration-processor-external-stage/pom.xml
Summary by CodeRabbit